repos/releases improvements #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: don't use assetid
loispostula
force-pushed
the
releases-assets
branch
from
310d305
to
bc78e55
Compare
|
@XAMPPRocky I' ve rebased this branch to incorporate #665 |
|
Thank you for your PR! |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #665
fixes #663
fixes #96
Implements:
PATCH /repos/{owner}/{repo}/releases/assets/{id}: Update a release assetDELETE /repos/{owner}/{repo}/releases/assets/{asset_id}: Delete a release assetGET /repos/{owner}/{repo}/releases/{id}: Get a release by idDELETE /repos/{owner}/{repo}/releases/{id}: Delete a releaseGET /repos/{owner}/{repo}/releases/{release_id}/assets: Get release assetsPOST <uploads_uri>/repos/{owner}/{repo}/releases/{release_id}/asset: Update a release assetChanges:
repo-subhandler, it makes senses as even the github documentation is segmented as suchapi::repo::releases::stream_assetsin favor ofapi::repo::release_assets::streamapi::repo::releases::get_assetin favor ofapi::repo::release_assets::getupload_urito be able to configure when to send to authentication headers for uploads (Due to Don't send Authorization headers to third-party services. #562)/!\ The changes from #665 are present in this PR, once the former is merged, I'll rebase this one