chore: switch to lazylock, bump minver to 1.80 #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eveeifyeve
changed the title
Author
|
Still panics! |
maflcko
reviewed
Aug 23, 2025
Contributor
maflcko
left a comment
maflcko
left a comment
There was a problem hiding this comment.
I'd say it would be easier to review if the bug you are trying to fix had easy and minimal steps to reproduce. This way, reviewers can understand and test the issue and the fix themselves.
| categories = ["web-programming::http-client"] | ||
| keywords = ["github", "github-api"] | ||
| rust-version = "1.73.0" | ||
| rust-version = "1.80" |
Contributor
There was a problem hiding this comment.
no objection to bumping, but this will drop the default rustc on vanilla Ubuntu noble (via apt): https://packages.ubuntu.com/noble/rustc, which is 1.75 right now.
Author
There was a problem hiding this comment.
It's required for it to not be poisioned, lazylock was implemented in 1.80.
Please see https://doc.rust-lang.org/beta/std/sync/struct.LazyLock.html for more info
Eveeifyeve
changed the title
Eveeifyeve
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #787.