Update to edition 2018

Cargo.toml

@@ -1,23 +1,24 @@
 [package]
 authors = ["Aaronepower <theaaronepower@gmail.com>"]
+categories = ["filesystem"]
 description = "A safe, reliable implementation of remove_dir_all for Windows"
+edition = "2018"
 include = [
-    "Cargo.toml",
-    "LICENCE-APACHE",
-    "LICENCE-MIT",
-    "src/**/*",
-    "README.md"
+  "Cargo.toml",
+  "LICENCE-APACHE",
+  "LICENCE-MIT",
+  "src/**/*",
+  "README.md",
 ]
+keywords = ["utility", "filesystem", "remove_dir", "windows"]
 license = "MIT/Apache-2.0"
 name = "remove_dir_all"
 readme = "README.md"
 repository = "https://github.com/XAMPPRocky/remove_dir_all.git"
 version = "0.5.3"
-keywords = ["utility", "filesystem", "remove_dir", "windows"]
-categories = ["filesystem"]
 
 [target.'cfg(windows)'.dependencies]
-winapi = { version = "0.3", features = ["std", "errhandlingapi", "winerror", "fileapi", "winbase"]}
+winapi = {version = "0.3", features = ["std", "errhandlingapi", "winerror", "fileapi", "winbase"]}
 
 [dev-dependencies]
-doc-comment = "0.3"
+doc-comment = "0.3"

src/fs.rs

@@ -114,7 +114,7 @@ pub fn remove_dir_all<P: AsRef<Path>>(path: P) -> io::Result<()> {
     }
 }
 
-fn remove_item(path: &Path, ctx: &mut RmdirContext) -> io::Result<()> {
+fn remove_item(path: &Path, ctx: &mut RmdirContext<'_>) -> io::Result<()> {
     if ctx.readonly {
         // remove read-only permision
         let mut permissions = path.metadata()?.permissions();
@@ -149,7 +149,7 @@ fn remove_item(path: &Path, ctx: &mut RmdirContext) -> io::Result<()> {
     Ok(())
 }
 
-fn move_item(file: &File, ctx: &mut RmdirContext) -> io::Result<()> {
+fn move_item(file: &File, ctx: &mut RmdirContext<'_>) -> io::Result<()> {
     let mut tmpname = ctx.base_dir.join(format! {"rm-{}", ctx.counter});
     ctx.counter += 1;
 
@@ -213,7 +213,7 @@ fn get_path(f: &File) -> io::Result<PathBuf> {
     )
 }
 
-fn remove_dir_all_recursive(path: &Path, ctx: &mut RmdirContext) -> io::Result<()> {
+fn remove_dir_all_recursive(path: &Path, ctx: &mut RmdirContext<'_>) -> io::Result<()> {
     let dir_readonly = ctx.readonly;
     for child in fs::read_dir(path)? {
         let child = child?;

src/lib.rs

@@ -5,9 +5,7 @@
 
 #![deny(missing_debug_implementations)]
 #![deny(missing_docs)]
-
-#[cfg(windows)]
-extern crate winapi;
+#![deny(rust_2018_idioms)]
 
 #[cfg(doctest)]
 #[macro_use]