Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for smalltalk #839

Merged
merged 4 commits into from
Apr 20, 2023
Merged

Add support for smalltalk #839

merged 4 commits into from
Apr 20, 2023

Conversation

jake-87
Copy link
Contributor

@jake-87 jake-87 commented Oct 26, 2021

Added support for the smalltalk programming language.

languages.json Outdated Show resolved Hide resolved
Co-authored-by: Spenser Black <spenserblack01@gmail.com>
@spenserblack
Copy link
Contributor

It seems like the issue is that tokei doesn't support filenames with multiple .s (.cs.st).

@jake-87
Copy link
Contributor Author

jake-87 commented Oct 29, 2021

That is definitely be a problem. Afaik, smalltalk programs almost always have two extensions on the end, such as .cs.st or .pck.st

@jake-87
Copy link
Contributor Author

jake-87 commented Oct 29, 2021

Would it be better to add both of those options as potential file extensions? E.G. "extensions": ["cs.st", "pck.st"]

@jake-87
Copy link
Contributor Author

jake-87 commented Nov 17, 2021

@spenserblack Should be fixed now

@spenserblack
Copy link
Contributor

spenserblack commented Nov 17, 2021

@jake-87 cool! I'm not a collaborator of tokei, though, so you'll probably want to ping @XAMPPRocky instead so they can run the workflows 🙂

@jake-87
Copy link
Contributor Author

jake-87 commented Nov 17, 2021

Ah, sorry about that. @XAMPPRocky, workflows should be good to go

@jake-87
Copy link
Contributor Author

jake-87 commented Apr 20, 2023

@XAMPPRocky ?

@XAMPPRocky
Copy link
Owner

XAMPPRocky commented Apr 20, 2023

Sorry for the late review. Thank you for your PR, and congrats on your first contribution! 🎉

@XAMPPRocky XAMPPRocky merged commit 5acdb19 into XAMPPRocky:master Apr 20, 2023
sbatial pushed a commit to sbatial/tokei that referenced this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants