Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re Start style guide #1084

Merged
merged 19 commits into from
Sep 28, 2022
Merged

Re Start style guide #1084

merged 19 commits into from
Sep 28, 2022

Conversation

JoranAngevaare
Copy link
Contributor

@JoranAngevaare JoranAngevaare commented Sep 26, 2022

Fix auto commenting style.

Fixes #1082

What changed:

Related issues/PRs:

@coveralls
Copy link

coveralls commented Sep 26, 2022

Coverage Status

Coverage increased (+0.03%) to 93.212% when pulling 8650a70 on style-guide into a821086 on master.

@JoranAngevaare JoranAngevaare marked this pull request as draft September 26, 2022 09:26
@JoranAngevaare JoranAngevaare marked this pull request as ready for review September 26, 2022 10:11
@dachengx
Copy link
Collaborator

@JoranAngevaare Great! I am also wondering whether we allow code style checking for each push in PR. Currently, only 'open' a PR will trigger the code style checking.

@JoranAngevaare
Copy link
Contributor Author

@JoranAngevaare Great! I am also wondering whether we allow code style checking for each push in PR. Currently, only 'open' a PR will trigger the code style checking.

@dachengx , thanks :) we did that previously. But it ended up completely bombarding PRs since it did not clean up comments from before. See e.g. this PR .

@dachengx
Copy link
Collaborator

@dachengx , thanks :) we did that previously. But it ended up completely bombarding PRs since it did not clean up comments from before. See e.g. this PR .

Get it. I approved this PR.

@JoranAngevaare JoranAngevaare merged commit 32dfab7 into master Sep 28, 2022
@JoranAngevaare JoranAngevaare deleted the style-guide branch September 28, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python style checking failed
3 participants