Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#998 nested conditions crash the site #1046

Closed
wants to merge 1 commit into from
Closed

Conversation

ziggy-cyb
Copy link
Collaborator

Description

Related to #998 . The SelectCondition component wasn't checking for nested conditions and was only checking against the field name of the condition. Given the data structure of nested conditions, this was causing an error as there is no reference to the field when referencing another condition.

  • Added new method to handle nested conditions

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Followed steps to reproduce issue in Conditions #998 , nested condition is selectable with no error.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and versioning
  • I have updated the architecture diagrams as per Contribute.md OR added an architectural decision record entry

@ziggy-cyb ziggy-cyb closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant