feat/submitter allow retry flag #1134
Conversation
queue-model/schema.prisma
Outdated
| @@ -17,4 +17,5 @@ model Submission { | |||
| return_reference String? | |||
| complete Boolean @default(false) | |||
| retry_counter Int | |||
| allow_retry Boolean | |||
There was a problem hiding this comment.
add the @default(true) annotation and regenerate the migration file (or manually change it). Otherwise when prisma attempt to run the migration on a non-empty table it'll start throwing errors
also congrats @default on the gh handle
| data: object, | ||
| url?: string, | ||
| allowRetry = true | ||
| ): Promise<QueueResponse> { | ||
| const rowData = { | ||
| data: JSON.stringify(data), | ||
| created_at: new Date(), | ||
| updated_at: new Date(), | ||
| webhook_url: url ?? null, |
There was a problem hiding this comment.
sorry, I only just spotted this, is this actually nullable / allowed to be null?
we should set url to non optional and webhook_url to non nullable
There was a problem hiding this comment.
ah yeah, I think initially I was thinking every form would put a line in the db and only wanted the ones that have a webhook url to be processed, but you're right we only push in submissions that have webhook urls
| /* | ||
| Warnings: | ||
|
|
||
| - Made the column `webhook_url` on table `Submission` required. This step will fail if there are existing NULL values in that column. |
There was a problem hiding this comment.
mind addressing this warning as well please. default empty string is fine
…rl fields to an empty string before running table modification
Description
In some instances, it's necessary that a webhook only be tried once in the case that it fails. This feature upgrades the form runner and submitter to accept an
allowRetryflag, set totrueorfalse, which determines whether the webhook should be tried more than once.model/schema/schema.tsto allowallowRetryon webhook outputConfiguration.allow_retryallowRetryif it's set on the output, or defaults totrueif notType of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce
the testing if necessary.
Checklist: