Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite class components as functional components #876

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

JamesBoadi
Copy link
Contributor

@JamesBoadi JamesBoadi commented Jul 27, 2022

Description

Some file types are still using classes instead of hooks and are not typescript files. These have been changed to typescript to improve functionality and readability. Class components have been converted to functional components. #356

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests

Checklist:

  • My changes do not introduce any new linting errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and versioning
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have rebased onto main and there are no code conflicts
  • I have checked deployments are working in all environments
  • I have updated the architecture diagrams as per Contribute.md

@JamesBoadi
Copy link
Contributor Author

JamesBoadi commented Aug 1, 2022

editor.tsx has a strange bug when converted to hooks.

declaration.js is being deprecated, so i dont think there is a need to convert this [762]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

1 participant