Add source_address to Telegram() (#516)

* use keyword arguments for Telegram() in tests

for readability

* add source_address to Telegram()

* add source to knx_event

* add telegram source

* cleaner log messages

- reordered Telegram.__str__()
- use strings for telegramtype and direction

* update HA knx_event

* forgot print statement

* telegramtype instead of type

* use keyword arguments for Telegram()

changelog.md

@@ -2,9 +2,13 @@
 
 ## Unreleased changes
 
+### HA integration
+
+- knx_event: renamed `address` to `destination` and added `source`, `telegramtype`, `direction` attributes.
+
 ### Internals
 
-- Telegram: `group_address` renamed to `destination_address`, to prepare support for other APCI services.
+- Telegram: `group_address` renamed to `destination_address`, to prepare support for other APCI services and add `source_address`
 - Farewell Travis CI; Welcome Github Actions!
 
 ## 0.15.6 Bugfix for StateUpater 2020-11-26

examples/example_tunnel.py

@@ -37,9 +37,13 @@ async def main():
     await tunnel.connect_udp()
     await tunnel.connect()
 
-    await tunnel.send_telegram(Telegram(GroupAddress("1/0/15"), payload=DPTBinary(1)))
+    await tunnel.send_telegram(
+        Telegram(destination_address=GroupAddress("1/0/15"), payload=DPTBinary(1))
+    )
     await asyncio.sleep(2)
-    await tunnel.send_telegram(Telegram(GroupAddress("1/0/15"), payload=DPTBinary(0)))
+    await tunnel.send_telegram(
+        Telegram(destination_address=GroupAddress("1/0/15"), payload=DPTBinary(0))
+    )
     await asyncio.sleep(2)
 
     await tunnel.connectionstate()

home-assistant-plugin/custom_components/xknx/__init__.py

@@ -325,8 +325,11 @@ async def telegram_received_cb(self, telegram):
         self.hass.bus.async_fire(
             "knx_event",
             {
-                "address": str(telegram.destination_address),
                 "data": telegram.payload.value,
+                "destination": str(telegram.destination_address),
+                "direction": telegram.direction.value,
+                "source": str(telegram.source_address),
+                "telegramtype": telegram.telegramtype.value,
             },
         )
 

test/devices_tests/binary_sensor_test.py

@@ -196,7 +196,9 @@ def test_process_wrong_payload(self):
         """Test process wrong telegram (wrong payload type)."""
         xknx = XKNX()
         binary_sensor = BinarySensor(xknx, "Warning", group_address_state="1/2/3")
-        telegram = Telegram(GroupAddress("1/2/3"), payload=DPTArray((0x1, 0x2, 0x3)))
+        telegram = Telegram(
+            destination_address=GroupAddress("1/2/3"), payload=DPTArray((0x1, 0x2, 0x3))
+        )
         with self.assertRaises(CouldNotParseTelegram):
             self.loop.run_until_complete(binary_sensor.process(telegram))