Add MemoryExtended services #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had some problem with mypy, so I need some help |
RealByron
commented
Nov 27, 2023
farmio
requested changes
Nov 27, 2023
|
|
farmio
reviewed
Nov 28, 2023
xknx/telegram/apci.py
Outdated
Comment on lines
534
to
537
| # inject [0x00] before 3 bytes address to enable unsigned int unpack | ||
| count, address, data = struct.unpack( | ||
| f"!BI{size}s", bytes([raw[2], 0x00]) + raw[3:] | ||
| ) |
There was a problem hiding this comment.
Suggested change
| # inject [0x00] before 3 bytes address to enable unsigned int unpack | |
| count, address, data = struct.unpack( | |
| f"!BI{size}s", bytes([raw[2], 0x00]) + raw[3:] | |
| ) | |
| count = raw[2] | |
| address = int.from_bytes(raw[3:6], "big") | |
| data = raw[6:] |
Here is an alternative approach to this. I think it is easier readable since no 0-Byte injection is required.
Optionally, you could raw[6:size] too.
Let me know what you think.
There was a problem hiding this comment.
Nice 👍 Can you do that for the other classes too and make CI pass? I think we would be fine to merge then.
There was a problem hiding this comment.
Sorry, I missed them, fix now
RealByron
force-pushed
the
add_MemoryExtended_services
branch
from
237da02 to
7a42f20
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1362 +/- ##
==========================================
+ Coverage 96.56% 96.59% +0.02%
==========================================
Files 150 150
Lines 9584 9695 +111
==========================================
+ Hits 9255 9365 +110
- Misses 329 330 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add MemoryExtended services : Read, ReadResponse, Write, WriteResponse
Fixes # (issue)
Type of change
Checklist