Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 2 or 4 byte float for weather air pressure #1618

Merged
merged 4 commits into from
Dec 8, 2024

Conversation

farmio
Copy link
Member

@farmio farmio commented Dec 8, 2024

Description

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The documentation has been adjusted accordingly
  • Tests have been added that prove the fix is effective or that the feature works
  • The changes are documented in the changelog (docs/changelog.md)

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.92%. Comparing base (bf9b26a) to head (dcd7c82).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
xknx/remote_value/remote_value_by_length.py 95.34% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1618      +/-   ##
==========================================
- Coverage   96.92%   96.92%   -0.01%     
==========================================
  Files         159      160       +1     
  Lines       10643    10688      +45     
==========================================
+ Hits        10316    10359      +43     
- Misses        327      329       +2     
Files with missing lines Coverage Δ
xknx/devices/weather.py 100.00% <100.00%> (ø)
xknx/remote_value/__init__.py 100.00% <100.00%> (ø)
xknx/remote_value/remote_value_by_length.py 95.34% <95.34%> (ø)

@farmio farmio merged commit f1e870d into main Dec 8, 2024
9 of 11 checks passed
@farmio farmio deleted the remote-value-auto-sense branch December 8, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant