[WIP] Add support for other APCI services #253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The example_info.py output looks like below:
|
2 tasks
basilfx
force-pushed
the
feature/apci_payload
branch
from
5406a84 to
505d237
Compare
10 tasks
|
I've rebased this PR, and split the first part of the commits into #510. If that one gets merged, I'll update this PR accordingly, and open another one for the next changes. At this point, four unit tests still fail, but the rest seems to work OK. |
This becomes unnecessary if the telegram type can be derrived from the payload.
Thi adds payload classes that represent APCI messages, such as GroupValueRead/Write/Response.
This adapts all Telegram payload objects to the corresponding APCI payload objects. It removes the need for `Telegram.telegramtype`.
This can be derived from the payload of the telegram.
basilfx
force-pushed
the
feature/apci_payload
branch
from
505d237 to
d815caf
Compare
basilfx
force-pushed
the
feature/apci_payload
branch
from
d815caf to
7e047d6
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for additional APCI services. APCI services are the actual payloads to communicate with actors. These payloads can be used for broadcast messages such as GroupValueWrite, but also for unicast messages such as MemoryRead. I need this to perform low(er)-level operations on my custom actors.
The main focus of this library was GroupValue payloads, so I had to refactor several parts of this library to make it more extensible. Fortunately, most of the higher-level API is still the same. In short:
Telegram.group_addressgot replaced byTelegram.address(APCI supports both types)Telegram.payloadshould be a class that extendsknx.telegram.apci.APCI. For instance, to write a DPT to a group address, you now useTelegram(.., payload=GroupValueWrite(DPTArray(..))).Telegram.telegramtypeis now encoded inknx.telegram.apci.APCI.code.I've added two examples (example_info.py and example_restart.py) to demonstate the new features.
Current limitation is that payloads can only be used in connectionless mode. This is not different from before, but several unicast messages are typically used with an active connection (that also supports sequencing and ACK/NACK on transport level). This would require more changes.
Current state is WIP and should not yet be merged. It's here to show and share my interest in this feature, and collect preliminary feedback. I'll continue on this one, but it needs a bit more time to fix the last part.