Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore unknown CEMI Messages #271

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Ignore unknown CEMI Messages #271

merged 1 commit into from
Mar 25, 2020

Conversation

farmio
Copy link
Member

@farmio farmio commented Mar 22, 2020

If we don't understand the CEMI Message ignore it and move on (eg. send TunnellingAck).
Previously we would raise CuldNotParseKNXIP and loose the connection because no Ack was sent.

From 03_06_03 EMI_IMI v01.03.03 AS:
4.1.3.3 Exception handling: unknown messages
General behaviour after reception of an unknown or unsupported message (this is, the cEMI Server does not know the received cEMI message code): the received message shall be ignored, this is, the cEMI Server shall generate no confirmation message.

closes #147
fixes home-assistant/core#32394
fixes #226 (again)

@farmio
If we don't understand the CEMI Message ignore it and move on (eg. se…
6817b2c 
…nd TunnellingAck). Previously we would raise CuldNotParseKNXIP and loose the connection.

If we don't understand the CEMI Message ignore it and move on (eg. send TunnellingAck).
Previously we would raise CuldNotParseKNXIP and loose the connection.
@farmio farmio requested a review from elupus March 22, 2020 23:56
Julius2342
Julius2342 approved these changes Mar 24, 2020
View reviewed changes
Copy link
Collaborator

@Julius2342 Julius2342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small question ...

Thank you for fixing this old bug :)

nodefeet added a commit to nodefeet/xknx that referenced this pull request Mar 24, 2020
@nodefeet
add PR XKNX#271 from farmio, hide logging
a4f3180
@farmio farmio merged commit ff3ba28 into XKNX:master Mar 25, 2020
@farmio farmio deleted the unknown-cemi branch March 25, 2020 07:29
@farmio farmio mentioned this pull request Apr 25, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julius2342 Julius2342 Julius2342 approved these changes

@elupus elupus Awaiting requested review from elupus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@farmio @Julius2342