Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust tests for more specific voluptuous 0.12.1 exceptions #526

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

spacegaier
Copy link
Contributor

Description

The new voluptuous version 0.12.1 provides improved exception messages if an In or NotIn requirement is not adhered to, by listing all the allowed values to help the user. Example:

value must be one of ['Auto', 'Comfort', 'Cool', 'Dry', 'Fan only', 'Frost Protection', 'Heat', 'Night', 'Off', 'Standby'] @ data['operation_modes'][1]

The xknx tests did not yet account for that and were still checking the old messages.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • The documentation has been adjusted accordingly
  • The changes generate no new warnings
  • Tests have been added that prove the fix is effective or that the feature works
  • The changes are documented in the changelog
  • The Homeassistant plugin has been adjusted in case of new config options

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.581% when pulling bf75a47 on spacegaier:vol-0.12.1-test-fixes into 4910563 on XKNX:master.

@farmio farmio merged commit bcbd1a2 into XKNX:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants