-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend APCI services #533
Merged
Merged
Extend APCI services #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basilfx
force-pushed
the
feature/apci_payload_extended
branch
from
December 16, 2020 00:54
47b7eeb
to
549d019
Compare
farmio
reviewed
Dec 16, 2020
farmio
reviewed
Dec 16, 2020
farmio
reviewed
Dec 16, 2020
farmio
reviewed
Dec 20, 2020
basilfx
force-pushed
the
feature/apci_payload_extended
branch
4 times, most recently
from
December 31, 2020 19:41
4bfbc6c
to
73f32f7
Compare
farmio
approved these changes
Dec 31, 2020
This is useful for request/response scenarios.
- example_restart.py will restart actor 1.2.3 - example_info.py will print actor information
basilfx
force-pushed
the
feature/apci_payload_extended
branch
from
January 1, 2021 14:12
8f050f3
to
c5be062
Compare
basilfx
force-pushed
the
feature/apci_payload_extended
branch
from
January 1, 2021 14:17
c5be062
to
03e7eca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This extends #519 to support more APCI services. Basically, this parses (or generates) other payloads for telegrams.
I've added two additional examples (
example_info.py
andexample_restart.py
) to demonstrate some new APCI services. The existingsexample_telegram_monitor.py
should be able to parse telegrams with these APCI services.Note that the KNX application layer specification defines when to send specific APCI services. For instance,
UserMemoryRead
should only be send in a point-to-point connection-oriented link (which is not supported by XKNX). But it is still possible to generate and send the payloads, e.g. for your own hardware :-)Type of change
Checklist: