Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend APCI services #533

Merged
merged 14 commits into from
Jan 1, 2021
Merged

Conversation

basilfx
Copy link
Contributor

@basilfx basilfx commented Dec 16, 2020

Description

This extends #519 to support more APCI services. Basically, this parses (or generates) other payloads for telegrams.

I've added two additional examples (example_info.py and example_restart.py) to demonstrate some new APCI services. The existings example_telegram_monitor.py should be able to parse telegrams with these APCI services.

Note that the KNX application layer specification defines when to send specific APCI services. For instance, UserMemoryRead should only be send in a point-to-point connection-oriented link (which is not supported by XKNX). But it is still possible to generate and send the payloads, e.g. for your own hardware :-)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • The documentation has been adjusted accordingly
  • The changes generate no new warnings
  • Tests have been added that prove the fix is effective or that the feature works
  • The changes are documented in the changelog
  • The Homeassistant plugin has been adjusted in case of new config options

@basilfx basilfx force-pushed the feature/apci_payload_extended branch from 47b7eeb to 549d019 Compare December 16, 2020 00:54
@coveralls
Copy link

coveralls commented Dec 16, 2020

Coverage Status

Coverage increased (+0.4%) to 94.859% when pulling 03e7eca on basilfx:feature/apci_payload_extended into 3ae35d0 on XKNX:master.

xknx/core/payload_reader.py Outdated Show resolved Hide resolved
@basilfx basilfx force-pushed the feature/apci_payload_extended branch 4 times, most recently from 4bfbc6c to 73f32f7 Compare December 31, 2020 19:41
@basilfx basilfx force-pushed the feature/apci_payload_extended branch from 8f050f3 to c5be062 Compare January 1, 2021 14:12
@basilfx basilfx force-pushed the feature/apci_payload_extended branch from c5be062 to 03e7eca Compare January 1, 2021 14:17
@farmio farmio merged commit d404075 into XKNX:master Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants