Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HA integration: Dynamic expose #563

Merged
merged 3 commits into from
Jan 16, 2021
Merged

HA integration: Dynamic expose #563

merged 3 commits into from
Jan 16, 2021

Conversation

farmio
Copy link
Member

@farmio farmio commented Jan 15, 2021

Description

  • HA integration: add knx.exposure_register service allowing to add and remove ExposeSensor at runtime
  • HA integration: move Expose classes to own module and create exposures after xknx.start() was called
  • XKNX: add Device.shutdown
    • delete its callbacks
    • remove RemoteValues from StateUpdater
    • remove from Devices
  • mitigate warnings in tests when calling __del__ when the loop is already closed

the intention behind this is the same as in #535

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • The documentation has been adjusted accordingly
  • The changes generate no new warnings
  • Tests have been added that prove the fix is effective or that the feature works
  • The changes are documented in the changelog
  • The Homeassistant plugin has been adjusted in case of new config options

@coveralls
Copy link

coveralls commented Jan 15, 2021

Coverage Status

Coverage decreased (-0.01%) to 94.851% when pulling b4339a9 on farmio:dynamic-expose into 725e787 on XKNX:master.

and create exposures after xknx.start()
- delete its callbacks
- remove RemoteValues from StateUpdater
- remove from Devices

also mitigate warnings in tests
@farmio farmio merged commit c455e2a into XKNX:master Jan 16, 2021
@farmio farmio deleted the dynamic-expose branch January 16, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants