Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include check to throw error if external choices list is not found #339

Merged
merged 2 commits into from
Aug 4, 2019
Merged

Include check to throw error if external choices list is not found #339

merged 2 commits into from
Aug 4, 2019

Conversation

WinnyTroy
Copy link
Member

@WinnyTroy WinnyTroy commented Jul 19, 2019 •
edited
Loading

Fixes #220

@WinnyTroy WinnyTroy requested a review from ukanga July 19, 2019 08:10
@WinnyTroy WinnyTroy force-pushed the throw_error_if_external_choices_list_is_empty branch from f2f12bb to 3b1d8ce Compare July 19, 2019 08:12
@codecov-io
Copy link

codecov-io commented Jul 19, 2019 •
edited
Loading

Codecov Report

Merging #339 into master will increase coverage by 0.22%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
+ Coverage   82.31%   82.54%   +0.22%     
==========================================
  Files          23       23              
  Lines        3252     3260       +8     
  Branches      758      760       +2     
==========================================
+ Hits         2677     2691      +14     
+ Misses        439      433       -6     
  Partials      136      136
Impacted Files Coverage Δ
pyxform/constants.py 100% <100%> (ø) ⬆️
pyxform/xls2json.py 78.05% <87.5%> (+0.24%) ⬆️
pyxform/question.py 92.17% <0%> (+3.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71501b9...08f5818. Read the comment docs.

@WinnyTroy WinnyTroy force-pushed the throw_error_if_external_choices_list_is_empty branch from 3b1d8ce to a5bcce9 Compare July 31, 2019 07:36
@ukanga ukanga merged commit f7f0e5d into XLSForm:master Aug 4, 2019
@WinnyTroy WinnyTroy deleted the throw_error_if_external_choices_list_is_empty branch August 5, 2019 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukanga ukanga ukanga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should throw error if external_choices list is not found
3 participants
@WinnyTroy @codecov-io @ukanga