Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Duplicate Names (warned by Qoanda) #741

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Fix Duplicate Names (warned by Qoanda) #741

merged 3 commits into from
Oct 2, 2024

Conversation

PythonSmall-Q
Copy link
Member

What does this PR aim to accomplish?:

  1. https://qodana.cloud/projects/3w8N2/reports/gLaEq?showingBaseline=GYQwNgzgpkA&openedProblem=MYVmwdgBgFgDhAJgGYFMBsI6oJwQIYTIxQBGOUAjKjOoonIpYiFIjJQMxRU6fCVk%2BLiGipRnNFGRA

  2. https://qodana.cloud/projects/3w8N2/reports/gLaEq?showingBaseline=GYQwNgzgpkA&openedProblem=KYZgxgDALFAmBGAmAHCAnGNA2CF4nDwEN4sBGMKIkAVljOADMMQB2G5KEUtNYBxsCKxkwCNmqsyQA

  3. https://qodana.cloud/projects/3w8N2/reports/gLaEq?showingBaseline=GYQwNgzgpkA&openedProblem=EwEwHALAjADCMCMBsBOYCCsZIgMwFMBDAdkNyVDFygDNhhCooEwQkMaaBjLsLmQhgF1CmRLgT4qQA

How does this PR accomplish the above?:

Delete them, of course

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributor's guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented on my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the GNU General Public License v3.0
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request can be closed at the will of the maintainer.
  9. I give this submission freely and claim no ownership to its content.
  • I have read the above and my PR is ready for review. Check this box to confirm

@PythonSmall-Q
Fix Duplicate Names (warned by Qoanda)
46c6751 
Signed-off-by: Shan Wenxiao <seanoj_noreply@yeah.net>
@hendragon-bot hendragon-bot bot added the user-script This issue or pull request is related to the main user script label Oct 2, 2024
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Qodana for JS

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

boomzero
boomzero approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@boomzero boomzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Note that copilot can be used to generate pull request summaries.

@boomzero boomzero merged commit c19ce3c into dev Oct 2, 2024
3 checks passed
@boomzero boomzero deleted the fix-duplicate-names branch October 2, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boomzero boomzero boomzero approved these changes

Assignees
No one assigned
Labels
size/S user-script This issue or pull request is related to the main user script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PythonSmall-Q @boomzero