Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 优化等待状态的显示 #743

Merged
merged 6 commits into from
Oct 10, 2024
Merged

feat: 优化等待状态的显示 #743

merged 6 commits into from
Oct 10, 2024

Conversation

PythonSmall-Q
Copy link
Member

Thank you for your contribution to the XMOJ-Script Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers, and completing the process outlined will help us review your commits quicker.

Please use this pull request template, or your pull request will be closed.

Please make sure you

  1. Base your code and PRs against the repository's developmental branch.

When you open a pull request, please delete the text above.


What does this PR aim to accomplish?:

How does this PR accomplish the above?:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributor's guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented on my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the GNU General Public License v3.0
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request can be closed at the will of the maintainer.
  9. I give this submission freely and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Shan Wenxiao <seanoj_noreply@yeah.net>
@hendragon-bot hendragon-bot bot added the user-script This issue or pull request is related to the main user script label Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Qodana for JS

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@boomzero
Copy link
Member

boomzero commented Oct 3, 2024

Qodana for JS

1 new problem were found

Inspection name Severity Problems
Implicitly declared global JavaScript variable ◽️ Notice 1
💡 Qodana analysis was run in the pull request mode: only the changed files were checked ☁️ View the detailed Qodana report

Contact Qodana team

Maybe consider fixing this?

Signed-off-by: Shan Wenxiao <seanoj_noreply@yeah.net>
@PythonSmall-Q
Copy link
Member Author

@boomzero done

@PythonSmall-Q
Copy link
Member Author

deepscan有的时候会扫描出qoanda没发现的问题

@PythonSmall-Q PythonSmall-Q linked an issue Oct 3, 2024 that may be closed by this pull request
2 tasks
@boomzero
Copy link
Member

boomzero commented Oct 3, 2024

deepscan有的时候会扫描出qoanda没发现的问题

deepscan有的时候会扫描出qoanda没发现的问题

Not enough to convince me to switch.
Paid products are always better than free ones.

Copy link
Member

@boomzero boomzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not test this now, so maybe you should?

@PythonSmall-Q
Copy link
Member Author

PythonSmall-Q commented Oct 4, 2024 via email

@PythonSmall-Q
Copy link
Member Author

我这里看上去没啥问题

@PythonSmall-Q
Copy link
Member Author

这个是paid的!只不过是opensource可以免费 在 2024-10-03 17:06:36,"Zhu Chenrui" @.> 写道: deepscan有的时候会扫描出qoanda没发现的问题 deepscan有的时候会扫描出qoanda没发现的问题 Not enough to convince me to switch. Paid products are always better than free ones. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you modified the open/close state.Message ID: @.>

我没说要switch,一起用挺好的

@boomzero
Copy link
Member

boomzero commented Oct 4, 2024

这个是paid的!只不过是opensource可以免费 在 2024-10-03 17:06:36,"Zhu Chenrui" @.> 写道: deepscan有的时候会扫描出qoanda没发现的问题 deepscan有的时候会扫描出qoanda没发现的问题 Not enough to convince me to switch. Paid products are always better than free ones. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you modified the open/close state.Message ID: @.>

好吧,+1

@PythonSmall-Q PythonSmall-Q merged commit 64904ec into dev Oct 10, 2024
2 of 3 checks passed
@PythonSmall-Q PythonSmall-Q deleted the waiting-icon branch October 10, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M user-script This issue or pull request is related to the main user script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 适配题目提交新状态
2 participants