Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug in search tpl #1482

Merged
merged 2 commits into from
Nov 16, 2024
Merged

fixed bug in search tpl #1482

merged 2 commits into from
Nov 16, 2024

Conversation

ggoffy
Copy link
Contributor

@ggoffy ggoffy commented Nov 14, 2024

search result was not shown after clicking "Show all results" as if isset($nomatch) && $nomatch == true is only fulfilled if there is no match

@ggoffy ggoffy requested a review from mambax7 November 14, 2024 14:48
Copy link
Collaborator

@mambax7 mambax7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this? It might be better:

<{if !isset($nomatch) || $nomatch != true}>

@ggoffy
Copy link
Contributor Author

ggoffy commented Nov 15, 2024

as it is the same it is ok for me, I have updated my PR

@mambax7 mambax7 merged commit 1c40fec into XOOPS:master Nov 16, 2024
1 of 11 checks passed
@mambax7
Copy link
Collaborator

mambax7 commented Nov 16, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants