Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line ending issues #3

Merged
merged 1 commit into from
Jan 15, 2016
Merged

Line ending issues #3

merged 1 commit into from
Jan 15, 2016

Conversation

geekwright
Copy link
Contributor

These changes were created automatically by cloning a fresh fork of the repo onto a linux system. Suspect the repository was not uniform when .gitattributes was added?

I think this PR should put everything right. There was a similar commit that went into 2.6 when we added the .gitattributes * text=auto to fix the line ending issues.

These changes were created automatically by cloning repo onto a linux
system. Suspect the repository was not uniform when .gitattributes was
added.
mambax7 added a commit that referenced this pull request Jan 15, 2016
@mambax7 mambax7 merged commit 5db9dc4 into XOOPS:master Jan 15, 2016
@mambax7
Copy link
Collaborator

mambax7 commented Jan 15, 2016

That's possible, but my understanding was that .gitattributes should standardize everything to Linux, regardless of what was on the developer's end?

@geekwright
Copy link
Contributor Author

It will, but in this case what was in the actual repo wasn't normalized. Once everything is in sync, it should work fine. This should be a one time clean up, and it should all be automatic and invisible now.

Thanks!

@mambax7
Copy link
Collaborator

mambax7 commented Jan 15, 2016

Thank you! :)

geekwright pushed a commit that referenced this pull request Mar 22, 2019
[ImgBot] Optimize images
geekwright added a commit to geekwright/XoopsCore25 that referenced this pull request Feb 10, 2020
GregMage added a commit to GregMage/XoopsCore25 that referenced this pull request Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants