You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using a timer from asio there is a possibility for a spurious call with success error code. Such behaviour could lead to UB or a crash by accessing deleted objects if code in timer callback check for error code and if it is a success it will do something with local objects. https://stackoverflow.com/questions/55200310/can-asio-timer-cancel-call-a-spurious-success
We should check timer usages in our code and fix any possible issue. An example of fixing such issue is in our PR.
Maybe if there are many places to be fixed we should write a wrapper for asio timer.
The text was updated successfully, but these errors were encountered:
Issue Description
When using a timer from asio there is a possibility for a spurious call with
success
error code. Such behaviour could lead to UB or a crash by accessing deleted objects if code in timer callback check for error code and if it is asuccess
it will do something with local objects.https://stackoverflow.com/questions/55200310/can-asio-timer-cancel-call-a-spurious-success
We should check timer usages in our code and fix any possible issue. An example of fixing such issue is in our PR.
Maybe if there are many places to be fixed we should write a wrapper for asio timer.
The text was updated successfully, but these errors were encountered: