Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept all valid currency codes in API #835

Closed
intelliot opened this issue Aug 29, 2023 · 0 comments · Fixed by #872
Closed

Accept all valid currency codes in API #835

intelliot opened this issue Aug 29, 2023 · 0 comments · Fixed by #872
Assignees
@kuznetsss
Milestone
2.1

Comments

@intelliot
Copy link
Collaborator

XRPLF/rippled#4566
@intelliot intelliot added the v2.1 label Aug 29, 2023
@intelliot intelliot added this to the 2.1 milestone Aug 29, 2023
@godexsoft godexsoft removed the v2.1 label Aug 29, 2023
@kuznetsss kuznetsss mentioned this issue Sep 25, 2023
Merged
kuznetsss added a commit that referenced this issue Oct 3, 2023
@kuznetsss
Add tests for special characters in currency validator (#872)
caaa01b 
Fixes #835

We are using xrpl's function to check currency code is valid so there is no need to change our code.
I added more test cases to be sure that clio supports characters added in xrpl.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuznetsss kuznetsss

Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

Add tests for characters in currency validator kuznetsss/clio
3 participants
@intelliot @godexsoft @kuznetsss