Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace all old instances of Config with New Config #1627

Open
wants to merge 33 commits into
base: develop
Choose a base branch
from

Conversation

PeterChen13579
Copy link
Collaborator

Fixes #1184
Previous PR's found here and here

@PeterChen13579 PeterChen13579 marked this pull request as draft September 4, 2024 19:53
@PeterChen13579 PeterChen13579 changed the title refactor: config refactor: Replace all old instances of Config with New Config Sep 5, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 59.27835% with 79 lines in your changes missing coverage. Please review.

Project coverage is 72.08%. Comparing base (e6cdb14) to head (55749d2).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/util/log/Logger.cpp 0.00% 16 Missing ⚠️
src/main/Main.cpp 0.00% 10 Missing ⚠️
src/web/Server.hpp 0.00% 0 Missing and 8 partials ⚠️
src/util/Taggable.hpp 40.00% 3 Missing and 3 partials ⚠️
src/web/dosguard/DOSGuard.cpp 40.00% 6 Missing ⚠️
src/util/newconfig/ConfigDefinition.hpp 37.50% 0 Missing and 5 partials ⚠️
src/app/ClioApplication.cpp 0.00% 3 Missing ⚠️
src/etl/ETLService.cpp 0.00% 3 Missing ⚠️
src/etl/Source.cpp 0.00% 3 Missing ⚠️
src/rpc/RPCEngine.hpp 0.00% 0 Missing and 3 partials ⚠️
... and 10 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1627      +/-   ##
===========================================
+ Coverage    71.83%   72.08%   +0.24%     
===========================================
  Files          279      280       +1     
  Lines        11731    11752      +21     
  Branches      5949     5944       -5     
===========================================
+ Hits          8427     8471      +44     
+ Misses        1732     1716      -16     
+ Partials      1572     1565       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PeterChen13579 PeterChen13579 marked this pull request as ready for review October 16, 2024 15:09
src/app/ClioApplication.cpp Outdated Show resolved Hide resolved
src/data/cassandra/SettingsProvider.cpp Show resolved Hide resolved
src/etl/ETLService.cpp Outdated Show resolved Hide resolved
src/etl/LoadBalancer.cpp Outdated Show resolved Hide resolved
src/main/Main.cpp Show resolved Hide resolved
src/web/dosguard/DOSGuard.cpp Outdated Show resolved Hide resolved
src/web/dosguard/WhitelistHandler.hpp Outdated Show resolved Hide resolved
tests/common/util/newconfig/ClioConfigFactories.hpp Outdated Show resolved Hide resolved
tests/unit/util/newconfig/JsonFileTests.cpp Outdated Show resolved Hide resolved
tests/unit/util/newconfig/JsonFileTests.cpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Config
4 participants