Skip to content

Commit

Permalink
Don't allow a payment to take anything from an expired offer.
Browse files Browse the repository at this point in the history
  • Loading branch information
@JoelKatz
JoelKatz committed Nov 8, 2013
1 parent 4620b66 commit 46861fa
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/ripple_app/paths/RippleCalc.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ TER RippleCalc::calcNodeAdvance (
// Offer is expired.
WriteLog (lsTRACE, RippleCalc) << "calcNodeAdvance: expired offer";
musUnfundedFound.insert(uOfferIndex);
continue;
}
else if (!saTakerPays.isPositive () || !saTakerGets.isPositive ())
{
Expand Down

1 comment on commit 46861fa

@vinniefalco
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a source-code comment explaining the bug, and why this fixes it. At the very least, a repeat of what is in the commit message ("Don't allow a payment to take anything from an expired offer.").

Please sign in to comment.