Fix unneeded copies in range some range for loops:

clang 10 warns about an unneeded copy for these range for loops (range-loop-construct warnings)
XRPLF · Apr 7, 2020 · ade5eb7 · ade5eb7
1 parent d097819
commit ade5eb7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/test/app/PayChan_test.cpp b/src/test/app/PayChan_test.cpp
@@ -946,7 +946,7 @@ struct PayChan_test : public beast::unit_test::suite
 
         Env env(*this);
         env.fund(XRP(10000), alice);
-        for (auto const a : bobs)
+        for (auto const& a : bobs)
         {
             env.fund(XRP(10000), a);
             env.close();
@@ -956,7 +956,7 @@ struct PayChan_test : public beast::unit_test::suite
             // create a channel from alice to every bob account
             auto const settleDelay = 3600s;
             auto const channelFunds = XRP(1);
-            for (auto const b : bobs)
+            for (auto const& b : bobs)
             {
                 env(create(alice, b, channelFunds, settleDelay, alice.pk()));
             }
@@ -990,7 +990,7 @@ struct PayChan_test : public beast::unit_test::suite
 
         auto const bobsB58 = [&bobs]() -> std::set<std::string> {
             std::set<std::string> r;
-            for (auto const a : bobs)
+            for (auto const& a : bobs)
                 r.insert(a.human());
             return r;
         }();

diff --git a/src/test/rpc/AccountCurrencies_test.cpp b/src/test/rpc/AccountCurrencies_test.cpp
@@ -153,7 +153,7 @@ class AccountCurrencies_test : public beast::unit_test::suite
         // does not change
         env(trust(alice, gw["USD"](100), tfSetFreeze));
         result = env.rpc ("account_lines", alice.human());
-        for (auto const l : result[jss::lines])
+        for (auto const& l : result[jss::lines])
             BEAST_EXPECT(
                 l[jss::freeze].asBool() == (l[jss::currency] == "USD"));
         result = env.rpc ("json", "account_currencies",