Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server provided fee is incorrect #229

Closed
vinniefalco opened this issue Dec 20, 2013 · 1 comment
Closed

Server provided fee is incorrect #229

vinniefalco opened this issue Dec 20, 2013 · 1 comment
Assignees
@ximinez

Comments

@vinniefalco
Copy link
Contributor

When a client requests that a trusted rippled server fill in the "Fee" field, it fills in a hard coded value that comes from the cfg file rather than looking at the ledger. This is in RPCHandler::transactionSign, using FEE_DEFAULT.
@ghost ghost assigned JoelKatz Dec 20, 2013
@vinniefalco vinniefalco reopened this Aug 18, 2015
rec pushed a commit to rec/rippled that referenced this issue Sep 9, 2015
fixes some silly mistakes references XRPLF#229
16999a1
@vinniefalco vinniefalco assigned ximinez and unassigned JoelKatz Feb 3, 2017
ximinez added a commit to ximinez/rippled that referenced this issue Feb 8, 2017
@ximinez
Unit tests of RPC "sign"
da1de61 
Specifically to demonstrate that XRPLF#229 is resolved.
@ximinez ximinez mentioned this issue Feb 10, 2017
Closed
@ximinez
Copy link
Collaborator

ximinez commented Feb 10, 2017

This issue has been resolved, and I have the unit tests to prove it. #2010

ximinez added a commit to ximinez/rippled that referenced this issue Feb 10, 2017
@ximinez
Add more 'sign' tests:
01babd8 
fix XRPLF#229
ximinez added a commit to ximinez/rippled that referenced this issue Feb 23, 2017
@ximinez
Add more 'sign' tests:
b7d2be5 
fix XRPLF#229
ximinez added a commit to ximinez/rippled that referenced this issue Feb 25, 2017
@ximinez
Add more 'sign' tests:
64838d9 
fix XRPLF#229
seelabs pushed a commit to seelabs/rippled that referenced this issue Mar 1, 2017
@ximinez @seelabs
Add more 'sign' tests:
3a55ce1 
fix XRPLF#229
seelabs pushed a commit to seelabs/rippled that referenced this issue Mar 1, 2017
@ximinez @seelabs
Add more 'sign' tests:
8fd40ce 
fix XRPLF#229
@seelabs seelabs closed this as completed in 73b4c81 Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ximinez ximinez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JoelKatz @vinniefalco @ximinez