Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UT make sure TrustSet fails if insufficient reserve to add a trustline #3

Closed
ahbritto opened this issue Dec 18, 2012 · 1 comment
Closed

UT make sure TrustSet fails if insufficient reserve to add a trustline #3

ahbritto opened this issue Dec 18, 2012 · 1 comment

Comments

@ahbritto
Copy link
Contributor

TrustSet should fail with an error if the line doesn't exist.
And with fail with a different error if the other party previously created the line.

Also consider playing with the quality options.
@gmosx gmosx mentioned this issue Mar 16, 2013
Closed
@BobWay BobWay mentioned this issue Jun 26, 2013
Closed
This was referenced Jul 1, 2013
Closed
Closed
@alexdupre alexdupre mentioned this issue Jul 11, 2013
Closed
@vinniefalco
Copy link
Contributor

If this is still a problem please create a new issue.

@lambda2003 lambda2003 mentioned this issue Feb 13, 2018
Closed
@professorhantzen professorhantzen mentioned this issue Mar 11, 2018
Closed
@dmitryrn dmitryrn mentioned this issue Jun 12, 2019
Closed
ximinez referenced this issue in ximinez/rippled Aug 12, 2019
@ximinez
[FOLD] Review feedback #3: More from @seelabs:
2c81a6a 
* Make a tag specifically for drop types (XRPAmount)
* Make the drops to decimal XRP conversion an XRPAmount member function.
  Requires moving DROPS_PER_XRP to XRPAmount.h. Includes unit tests.
* Fix some other problematic XRPAmount unit tests.
@ximinez ximinez mentioned this issue Aug 13, 2019
Merged
ximinez referenced this issue in ximinez/rippled Aug 19, 2019
@ximinez
[FOLD] Review feedback #3: More from @seelabs:
915d2a8 
* Make a tag specifically for drop types (XRPAmount)
* Make the drops to decimal XRP conversion an XRPAmount member function.
  Requires moving DROPS_PER_XRP to XRPAmount.h. Includes unit tests.
* Fix some other problematic XRPAmount unit tests.
ximinez referenced this issue in ximinez/rippled Aug 26, 2019
@ximinez
[FOLD] Review feedback #3: More from @seelabs:
f922e5e 
* Make a tag specifically for drop types (XRPAmount)
* Make the drops to decimal XRP conversion an XRPAmount member function.
  Requires moving DROPS_PER_XRP to XRPAmount.h. Includes unit tests.
* Fix some other problematic XRPAmount unit tests.
ximinez referenced this issue in ximinez/rippled Sep 9, 2019
@ximinez
[FOLD] Review feedback #3: More from @seelabs:
83c80b6 
* Make a tag specifically for drop types (XRPAmount)
* Make the drops to decimal XRP conversion an XRPAmount member function.
  Requires moving DROPS_PER_XRP to XRPAmount.h. Includes unit tests.
* Fix some other problematic XRPAmount unit tests.
ximinez referenced this issue in ximinez/rippled Oct 2, 2019
@ximinez
[FOLD] Review feedback #3: More from @seelabs:
1948d80 
* Make a tag specifically for drop types (XRPAmount)
* Make the drops to decimal XRP conversion an XRPAmount member function.
  Requires moving DROPS_PER_XRP to XRPAmount.h. Includes unit tests.
* Fix some other problematic XRPAmount unit tests.
@luleigreat luleigreat mentioned this issue Dec 14, 2021
Open
natenichols added a commit to natenichols/rippled that referenced this issue Dec 15, 2021
@natenichols
# This is a combination of 3 commits.
72d75c3 
# This is the 1st commit message:

[FOLD] rebase

# This is the commit message XRPLF#2:

[FOLD] Formatting

# This is the commit message XRPLF#3:

[FOLD] format test
@jonaagenilsen jonaagenilsen mentioned this issue Jul 6, 2022
Merged
@ajkagy ajkagy mentioned this issue Feb 7, 2023
Closed
@mtrippled mtrippled mentioned this issue Mar 13, 2023
Merged
6 tasks
This was referenced Mar 23, 2023
Open
Open
Bronek added a commit to Bronek/rippled that referenced this issue Nov 29, 2023
@Bronek
Diagnosing MSVC ICE build error XRPLF#3
9c20d6e
Bronek added a commit to Bronek/rippled that referenced this issue Nov 29, 2023
@Bronek
Revert "Diagnosing MSVC ICE build error XRPLF#3"
8b8533c 
This reverts commit 9c20d6e.
Bronek added a commit to Bronek/rippled that referenced this issue Nov 29, 2023
@Bronek
Diagnosing MSVC ICE build error XRPLF#3
a2e8011
vlntb added a commit to vlntb/rippled that referenced this issue Dec 16, 2024
@vlntb
Addressing review comments XRPLF#3
f54fb8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahbritto @vinniefalco