Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path bug #5

Closed
jedmccaleb opened this issue Jan 6, 2013 · 3 comments
Closed

path bug #5

jedmccaleb opened this issue Jan 6, 2013 · 3 comments
Assignees

Comments

@jedmccaleb
Copy link
Contributor

more on this bug:

  1. i set up 4 accounts.
  2. acct 4 trusted all the other accts for 100 usd
  3. acct 2 acted as a nexus for acct 1 and 3, was trusted by 1 and 3 for 100 usd
  4. acct 2 sent acct 3 a 75 iou
  5. acct 1 sent a 25 usd iou to acct 2

a path should go from 1 to 3 thru 2, the nexus; however,

instead, 1 shows an iou to acct 4 for 25 usd, this should show as an iou from 2, the nexus.
also, acct 3 showed initally no increase in its iou from 2 and incorrectly showed its dollar balance increasing by $100 (the trust granted amount) rather than the iou amount sent. when i logged out twice, the right balance and iou was shown.
the system incorrectly created an iou balance from 1 to 4 even thou nothing was sent to 4 and the nexus path of 1 to 3 was from 2. the system incorrectly created a path thru 4 instead of 2.

@ghost ghost assigned ahbritto Jan 6, 2013
@ahbritto
Copy link
Contributor

ahbritto commented Jan 6, 2013

Before trying anything:

Step 5 should be impossible:

  • Account 1 has no IOUs, can not obtain IOUs, and can only issue its own IOUs.
  • Account 4 is the only account that accepts 1's IOUs.
  • No account accepts 4's IOUs. Making account 4 a dead end from account 1.
  • Therefore, there is no route from 1 to 2. Which is what step 5 tries to utilize.

There might be a path a path from 1 to 3 through nexus 2, if 1 held nexus IOUs.

I will verify code performs as expected.

ahbritto added a commit that referenced this issue Jan 7, 2013
@ahbritto
Copy link
Contributor

ahbritto commented Jan 7, 2013

Code behaves as expected:

  • Path finding fails to find a path.
  • Send with default path finding fails to find a path.
  • Balances end up as expected.

New unit test "Issue #5" explicitly tests related behaviour.

The problems described might have to do with client interpretation.

@ahbritto
Copy link
Contributor

This bug is old. Closing for clarity.

wufeipeng pushed a commit to peersafe/rippled that referenced this issue Nov 20, 2017
…nstruct-tree

fix an issue on casting long in query_result
ximinez referenced this issue in ximinez/rippled Aug 15, 2019
* Fix a couple of gcc/clang build errors
* Explanatory comments
ximinez referenced this issue in ximinez/rippled Aug 19, 2019
* Fix a couple of gcc/clang build errors
* Explanatory comments
ximinez referenced this issue in ximinez/rippled Aug 26, 2019
* Fix a couple of gcc/clang build errors
* Explanatory comments
ximinez referenced this issue in ximinez/rippled Sep 9, 2019
* Fix a couple of gcc/clang build errors
* Explanatory comments
ximinez referenced this issue in ximinez/rippled Oct 2, 2019
* Fix a couple of gcc/clang build errors
* Explanatory comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants