Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use std::size in place of std::extent #3403

Closed
wants to merge 2 commits into from
Closed

Use std::size in place of std::extent #3403

wants to merge 2 commits into from

Conversation

HowardHinnant
Copy link
Contributor

  • Fixes RIPD-269

scottschurr
scottschurr approved these changes May 14, 2020
View reviewed changes
Copy link
Collaborator

@scottschurr scottschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice simplification!

cjcobb23
cjcobb23 approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@cjcobb23 cjcobb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@HowardHinnant HowardHinnant added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label May 14, 2020
nbougalis
nbougalis approved these changes May 27, 2020
View reviewed changes
src/test/core/SociDB_test.cpp Outdated
int dbInitCount = std::extent<decltype(dbInit)>::value;
for (int i = 0; i < dbInitCount; ++i)
auto dbInitCount = std::size(dbInit);
for (auto i = 0u; i < dbInitCount; ++i)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change needed, but why not for (auto const s : dbInit)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be good too. I'll go ahead and change it. I was so intent on just doing the mechanical change at hand I didn't take my blinders off and look at the surrounding code.

This was referenced May 29, 2020
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcobb23 cjcobb23 cjcobb23 approved these changes

@scottschurr scottschurr scottschurr approved these changes

@nbougalis nbougalis nbougalis approved these changes

Assignees

@scottschurr scottschurr

@cjcobb23 cjcobb23

Labels
Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HowardHinnant @nbougalis @scottschurr @cjcobb23