AmendmentTable improvements #3404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seelabs
approved these changes
May 15, 2020
|
|
||
| { | ||
| std::lock_guard sl(mutex_); | ||
| amendments.reserve(amendmentMap_.size()); |
Codecov Report
@@ Coverage Diff @@
## develop #3404 +/- ##
===========================================
+ Coverage 70.44% 70.45% +0.01%
===========================================
Files 682 682
Lines 54392 54389 -3
===========================================
+ Hits 38315 38321 +6
+ Misses 16077 16068 -9
Continue to review full report at Codecov.
|
nbougalis
reviewed
May 15, 2020
| { | ||
| // Forward to the const version of get. | ||
| return const_cast<AmendmentState*>( | ||
| std::as_const(*this).get(amendmentHash, sl)); |
There was a problem hiding this comment.
What's this now? std::as_const? Neat.
gregtatcam
approved these changes
May 18, 2020
scottschurr
added
the
Ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on retiring amendments I made a number of improvements to the AmendmentTable and its unit tests. Since we're not moving forward with retiring amendments, this pull request contains the improvements to the AmendmentTable and its unit tests that I believe we want to keep.
This code should look very familiar to the reviewers. It's just selected favorite highlights from the retiring amendments pull request. Thanks for looking it over again.