Code

Redesign stoppable objects#3741

Code

Closed

thejohnfreeman wants to merge 66 commits intoXRPLF:developXRPLF/rippled:developfrom thejohnfreeman:stoppablethejohnfreeman/rippled:stoppableCopy head branch name to clipboard

+779-2,458

Commits

Commits on Jan 22, 2021

• Remove Stoppable::onPrepare

  thejohnfreeman

  committed
  0747c09

  Copy full SHA for 0747c09

• [fold] Move timer from RootStoppable to LoadManager

  thejohnfreeman

  committed
  73e6347

  Copy full SHA for 73e6347

• [fold] Call stopped() in LedgerCleanerImp::onStop

  thejohnfreeman

  committed
  6b56845

  Copy full SHA for 6b56845

• [fold] Remove Stoppable from base classes of OrderBookDB, LedgerMaster

  thejohnfreeman

  committed
  2180d82

  Copy full SHA for 2180d82

• [fold] Call stopped() in SHAMapStoreImp::onStop

  thejohnfreeman

  committed
  e8f8d04

  Copy full SHA for e8f8d04

• [fold] Call stopped() in NodeStore::Database::onStop

  thejohnfreeman

  committed
  0282848

  Copy full SHA for 0282848

• [fold] NodeStoreScheduler is not a Stoppable

  Show description for 50a9967
  thejohnfreeman

  committed
  50a9967

  Copy full SHA for 50a9967

• [fold] Call stopped() in ServerHandlerImp::onStop

  thejohnfreeman

  committed
  9af6acc

  Copy full SHA for 9af6acc

• [fold] Stop NodeStore::TaskQueue from NodeStore::DatabaseShardImp::onStop

  thejohnfreeman

  committed
  1bb43f7

  Copy full SHA for 1bb43f7

• [fold] Move JobCounter from RootStoppable to JobQueue

  Show description for 94c830c
  thejohnfreeman

  committed
  94c830c

  Copy full SHA for 94c830c

• [fold] Call stopped() in OverlayImpl::onStop

  thejohnfreeman

  committed
  ef7d968

  Copy full SHA for ef7d968

• [fold] Call stopped() in NodeStore::DatabaseShardImp::onStop

  thejohnfreeman

  committed
  c27f440

  Copy full SHA for c27f440

• [fold] Call stopped() in PerfLogImp::onStop

  thejohnfreeman

  committed
  aad8a32

  Copy full SHA for aad8a32

• [fold] Remove Stoppable::{stopped,onChildrenStopped}

  thejohnfreeman

  committed
  59557fe

  Copy full SHA for 59557fe

• [fold] Remove Stoppable::{setParent,getRoot}

  thejohnfreeman

  committed
  78050db

  Copy full SHA for 78050db

• [fold] Remove RootStoppable::start and Stoppable::startRecursive

  thejohnfreeman

  committed
  251bf3e

  Copy full SHA for 251bf3e

• [fold] Inline Application::start

  thejohnfreeman

  committed
  299e059

  Copy full SHA for 299e059

• [fold] LoadManager is not a Stoppable

  thejohnfreeman

  committed
  ad12f0e

  Copy full SHA for ad12f0e

• [fold] PeerFinder::Manager is not a Stoppable

  thejohnfreeman

  committed
  ffa6c2c

  Copy full SHA for ffa6c2c

• [fold] Remove unused include

  thejohnfreeman

  committed
  4d32cf6

  Copy full SHA for 4d32cf6

• [fold] ServerHandlerImp is not a Stoppable

  thejohnfreeman

  committed
  f331b3f

  Copy full SHA for f331b3f

• [fold] LedgerCleaner is not a Stoppable

  thejohnfreeman

  committed
  f8bd287

  Copy full SHA for f8bd287

• [fold] NetworkOPsImp is not a Stoppable

  thejohnfreeman

  committed
  15a9472

  Copy full SHA for 15a9472

• [fold] Remove unused include

  thejohnfreeman

  committed
  eb68656

  Copy full SHA for eb68656

• [fold] GRPCServer is not a Stoppable

  thejohnfreeman

  committed
  2d26155

  Copy full SHA for 2d26155

• [fold] PerfLogImp is not a Stoppable

  thejohnfreeman

  committed
  727b349

  Copy full SHA for 727b349

• [fold] Use a fixture for PerfLog tests

  thejohnfreeman

  committed
  3e08270

  Copy full SHA for 3e08270

• [fold] OverlayImpl is not a Stoppable

  thejohnfreeman

  committed
  15b7da1

  Copy full SHA for 15b7da1

• [fold] InboundTransactionsImp is not a Stoppable

  thejohnfreeman

  committed
  4a150d1

  Copy full SHA for 4a150d1

• [fold] InboundLedgersImp is not a Stoppable

  thejohnfreeman

  committed
  2b35d46

  Copy full SHA for 2b35d46

• [fold] ReportingETL is not a Stoppable

  thejohnfreeman

  committed
  833767e

  Copy full SHA for 833767e

Commits on Jan 23, 2021

• [fold] PgPool is not a Stoppable

  thejohnfreeman

  committed
  77a6ac7

  Copy full SHA for 77a6ac7

• [fold] NodeStore::Database is not a Stoppable

  thejohnfreeman

  committed
  8c5deef

  Copy full SHA for 8c5deef

• [fold] SHAMapStoreImp is not a Stoppable

  thejohnfreeman

  committed
  023998b

  Copy full SHA for 023998b

• [fold] ShardArchiveHandler is not a Stoppable

  thejohnfreeman

  committed
  21db979

  Copy full SHA for 21db979

• [fold] JobQueue is not a Stoppable

  thejohnfreeman

  committed
  0b14202

  Copy full SHA for 0b14202

• [fold] Remove Stoppable

  thejohnfreeman

  committed
  fe5d5db

  Copy full SHA for fe5d5db

• [fold] Document ClosureCounter and Workers

  thejohnfreeman

  committed
  ddf177e

  Copy full SHA for ddf177e

• [fold] Remove mentions of Stoppable

  thejohnfreeman

  committed
  846b0c7

  Copy full SHA for 846b0c7

• [fold] Rename HTTPDownloader::{onStop -> stop}

  thejohnfreeman

  committed
  6a45a85

  Copy full SHA for 6a45a85

Commits on Jan 26, 2021

• [fold] review fixes

  thejohnfreeman

  committed
  5e892a7

  Copy full SHA for 5e892a7

Commits on Jan 27, 2021

• [fold] Merge 1.7.0-b12

  thejohnfreeman

  committed
  cd9cd6e

  Copy full SHA for cd9cd6e

• [fold] LedgerReplayer is not a Stoppable

  thejohnfreeman

  committed
  e8a8d3e

  Copy full SHA for e8a8d3e

Commits on Jan 31, 2021

• [fold] Use CTAD

  thejohnfreeman

  committed
  bd22635

  Copy full SHA for bd22635

• [fold] Move start, stop to PerfLog interface and use it

  thejohnfreeman

  committed
  a40ddf2

  Copy full SHA for a40ddf2

• [fold] Prefer narrow capture list

  thejohnfreeman

  committed
  6fe6f26

  Copy full SHA for 6fe6f26

• [fold] Rename Timer::{start -> async_wait}

  thejohnfreeman

  committed
  905a274

  Copy full SHA for 905a274

• [fold] Move start, stop to Overlay interface and use it

  thejohnfreeman

  committed
  f556e07

  Copy full SHA for f556e07

Commits on Feb 1, 2021

• [fold] Stop at the beginning of every NodeStore::Database destructor

  thejohnfreeman

  committed
  a4fbb6c

  Copy full SHA for a4fbb6c

• [fold] Rename Workers::{pauseAllThreadsAndWait -> stop}

  thejohnfreeman

  committed
  954c6fb

  Copy full SHA for 954c6fb

• [fold] Ignore overlay when it is missing

  thejohnfreeman

  committed
  3596ce5

  Copy full SHA for 3596ce5

Commits on Feb 2, 2021

• [fold] Fix comment

  thejohnfreeman

  committed
  fcba4a6

  Copy full SHA for fcba4a6

Commits on Feb 3, 2021

• [fold] Stop ServerHandlerImp

  thejohnfreeman

  committed
  92e9c6a

  Copy full SHA for 92e9c6a

Commits on Feb 7, 2021

• [fold] Rearrange stop sequence

  thejohnfreeman

  committed
  01521e5

  Copy full SHA for 01521e5

• Merge 1.7.0-rc2

  thejohnfreeman

  committed
  5e05663

  Copy full SHA for 5e05663

Commits on Feb 8, 2021

• Fix declaration of CassandraBackend::counters_

  thejohnfreeman

  committed
  6a025ff

  Copy full SHA for 6a025ff

• [fold] review fixes

  thejohnfreeman

  committed
  51adc26

  Copy full SHA for 51adc26

• [fold] Move LedgerCleaner from LedgerMaster to ApplicationImp

  thejohnfreeman

  committed
  e531354

  Copy full SHA for e531354

Commits on Mar 15, 2021

• [fold] Merge 1.8.0-b1

  thejohnfreeman

  committed
  5bfc16f

  Copy full SHA for 5bfc16f

Commits on Mar 23, 2021

• [fold] Add missing include

  thejohnfreeman

  committed
  2a39b7c

  Copy full SHA for 2a39b7c

• Fix compilation of krb5 dependency with GCC 10

  Show description for d3c1c1f
  thejohnfreeman

  committed
  d3c1c1f

  Copy full SHA for d3c1c1f

Commits on Apr 2, 2021

• Merge 1.8.0-b2

  thejohnfreeman

  committed
  e74afc3

  Copy full SHA for e74afc3

• [fold] Put PgPool behind conditional compilation

  thejohnfreeman

  committed
  f1beb4f

  Copy full SHA for f1beb4f

• [fold] More conditional compilation

  thejohnfreeman

  committed
  145f5a1

  Copy full SHA for 145f5a1

Commits on Apr 30, 2021

• [fold] Requested changes

  thejohnfreeman

  committed
  220f440

  Copy full SHA for 220f440

Commits on May 13, 2021

• [fold] Requested changes

  thejohnfreeman

  committed
  7b459ca

  Copy full SHA for 7b459ca