Support DNS in gRPC connection for Reporting Mode ETL #3789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximinez
requested changes
Jun 3, 2021
There was a problem hiding this comment.
https://travis-ci.com/github/ripple/rippled/jobs/489850786#L675
Edit: Woops. I meant to save this as a draft. Now that it's here, I don't think I can do anything about it. This is a link to the Windows compiler error about the unreferenced e variable in ETLSource.cpp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for specifying ETL sources with DNS records, as opposed to just raw IP addresses. This change only affects reporting mode.
This change is