Maintenance of Offer and PayStrand unit tests #3853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seelabs
suggested changes
May 25, 2021
src/test/app/PayStrand_test.cpp
Outdated
| D{alice, gw, usdC}, | ||
| B{USD.issue(), xrpIssue()}, | ||
| XRPS{bob})); | ||
| BEAST_EXPECT(ter == temBAD_PATH); | ||
| } |
There was a problem hiding this comment.
Sorry, I messed up this test. Here's a patch with the correction: seelabs@4173a17
seelabs
approved these changes
May 26, 2021
thejohnfreeman
approved these changes
May 26, 2021
scottschurr
added
the
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
While doing other work I came across two unit tests that needed maintenance.
Context of Change
Type of Change
Only unit tests were affected by this change, so it does not need to be mentioned in the release notes.