-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand Linux test matrix #4454
Merged
Merged
Expand Linux test matrix #4454
Changes from 22 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
2287430
Factor out composite action for build step
thejohnfreeman 39a925d
Python is no longer used directly
thejohnfreeman 13f98a5
Pass name of profile
thejohnfreeman 1cd1190
Fix build script
thejohnfreeman bc214c6
Target self-hosted runner
thejohnfreeman 5a970e3
Expand matrix on compiler, configuration, and unity
thejohnfreeman f6afe68
Set path to compiler in profile
thejohnfreeman 9c9649a
Add missing profile name
thejohnfreeman 02ca3ef
Move matrix objects to include section
thejohnfreeman 12f0ecc
Use [buildenv] instead of [env]
thejohnfreeman 35b6460
Separate jobs to build Conan dependency caches
thejohnfreeman 1ca0b11
Cannot set [buildenv] from command line
thejohnfreeman 6255be8
Shell-quote JSON on command line
thejohnfreeman 6119069
Add missing profile name
thejohnfreeman 149f484
Substitute for missing environment variable
thejohnfreeman 49e0135
Archive and compress cache artifact
thejohnfreeman 55b14e7
Fix artifact download path
thejohnfreeman 95f360c
Try heavy runners
thejohnfreeman ff47ee2
Try again
thejohnfreeman 77a5512
Merge branch develop
thejohnfreeman 53e6bb8
Merge upstream develop
thejohnfreeman 36e104a
Fix Conan export in build action
thejohnfreeman bfbcaff
Try to restore macos workflow
thejohnfreeman f9b9cfa
Migrate from deprecated set-output command
thejohnfreeman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
name: build | ||
inputs: | ||
generator: | ||
default: null | ||
configuration: | ||
required: true | ||
cmake-args: | ||
default: null | ||
# An implicit input is the environment variable `build_dir`. | ||
runs: | ||
using: composite | ||
steps: | ||
- name: export custom recipes | ||
shell: bash | ||
run: conan export external/snappy snappy/1.1.9@ | ||
- name: install dependencies | ||
shell: bash | ||
run: | | ||
mkdir ${build_dir} | ||
cd ${build_dir} | ||
conan install \ | ||
--output-folder . \ | ||
--build missing \ | ||
--settings build_type=${{ inputs.configuration }} \ | ||
.. | ||
- name: configure | ||
shell: bash | ||
run: | | ||
cd ${build_dir} | ||
cmake \ | ||
${{ inputs.generator && format('-G {0}', inputs.generator) || '' }} \ | ||
-DCMAKE_TOOLCHAIN_FILE:FILEPATH=build/generators/conan_toolchain.cmake \ | ||
-DCMAKE_BUILD_TYPE=${{ inputs.configuration }} \ | ||
${{ inputs.cmake-args }} \ | ||
.. | ||
- name: build | ||
shell: bash | ||
run: | | ||
cmake \ | ||
--build ${build_dir} \ | ||
--config ${{ inputs.configuration }} \ | ||
--parallel ${NUM_PROCESSORS:-$(nproc)} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe push a new ubuntu 18.04 image with GCC-10?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 18.04?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we can test it into perpetuity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I think there's a case to be made to pick one configuration to test on multiple versions of Ubuntu. I don't have an 18.04 image with everything available right now. Won't take me long to make one, but perhaps we can punt that to a future PR?