Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRIVIAL] Add missing includes #4555

Merged
merged 1 commit into from
Jun 5, 2023
Merged

[TRIVIAL] Add missing includes #4555

merged 1 commit into from
Jun 5, 2023

Conversation

seelabs
Copy link
Collaborator

@seelabs seelabs commented Jun 5, 2023

gcc 13.1 failed to compile rippled due to missing headers. This patch adds the needed headers.

  • [ X] Bug fix (non-breaking change which fixes an issue)

@seelabs
Add missing includes:
23ebda7 
gcc 13.1 failed to compile rippled due to missing headers. This patch
adds the needed headers.
@seelabs seelabs requested a review from pwang200 June 5, 2023 01:39
@seelabs
Copy link
Collaborator Author

seelabs commented Jun 5, 2023

@intelliot I would like to get this into the upcoming release. It is trivial, but without it people won't be able to build with gcc 13.

@seelabs seelabs added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Jun 5, 2023
@intelliot intelliot added Build System Trivial Simple change with minimal effect, or already tested. Only needs one approval. labels Jun 5, 2023
@intelliot intelliot added this to the 1.11.0 milestone Jun 5, 2023
pwang200
pwang200 approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@pwang200 pwang200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@intelliot intelliot merged commit c9a586c into XRPLF:develop Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwang200 pwang200 pwang200 approved these changes

@thejohnfreeman thejohnfreeman thejohnfreeman approved these changes

Assignees

@pwang200 pwang200

Labels
Build System Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.
Projects
Core Ledger
Archived in project
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@seelabs @pwang200 @thejohnfreeman @intelliot