-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #4595
Update dependencies #4595
Conversation
FWIW, this branch does not build for me on my local machine. I'm using clang on macOS. Conan is apparently using boost 1.77. I made a commit that does build on my local machine. Basically I turned selected implicit conversions to |
Okay, that last comment was not accurate since I did not clear the |
Those fixes worked for me on macOS 12.6.3, Clang 14.0.0, Boost 1.82.0. I copied them over. Let's see how they do in CI. CI uses Clang 16. I'm installing that in my VM for testing now. |
Clang 16 fails because of a compiler regression involving |
Compiler flag worked. No errors, but have some residual warnings. Will work on eliminating them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest version is working for me. Thanks for doing this!
I'm seeing the following error:
I haven't looked into this yet, just posting the issue in case anyone knows of a quick fix. |
@seelabs, I saw that error. As I recall it was cleaned up when I cleared my |
@scottschurr Thanks! That got me past that error. |
RocksDB 6.x.x is not ready for GCC 13 (facebook/rocksdb#11157). I'll try adapting a recipe for RocksDB 8.x.x Monday and test compile our code against it. |
I was able to build and test this with gcc 13, but only by manually editing some files in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds fine in Windows. I'm curious to see how this interacts with #4596
for next week: if this is ready to merge, go ahead and bring it up-to-date with the base branch (preferably with a merge commit). (I don't have permission to push to the PR branch) |
Suggested commit message:
|
Note: If you had built the project prior to this commit: After this commit, you may need to:
|
This reverts commit cb09e61.
Use the most recent versions in ConanCenter. * Due to a bug in Clang 16, you may get a compile error: "call to 'async_teardown' is ambiguous" * A compiler flag workaround is documented in `BUILD.md`. * At this time, building this with gcc 13 may require editing some files in `.conan/data` * A patch to support gcc13 may be added in a later PR. --------- Co-authored-by: Scott Schurr <scott@ripple.com>
Use the most recent versions in ConanCenter. * Due to a bug in Clang 16, you may get a compile error: "call to 'async_teardown' is ambiguous" * A compiler flag workaround is documented in `BUILD.md`. * At this time, building this with gcc 13 may require editing some files in `.conan/data` * A patch to support gcc13 may be added in a later PR. --------- Co-authored-by: Scott Schurr <scott@ripple.com>
This change updates our dependencies to the most recent versions in Conan Center.
cassandra-cpp-driver
cannot compile as C++20. I don't know how the Clio team is doing it.The only code changes required are related to (a) missing includes and (b) multiple
string_view
s in Boost. rippled uses Boost.Beast which now uses aboost::core::string_view
that is different fromboost::utility::string_view
.boost::core::string_view
was added to Boost on Oct 4, 2021, after the release of 1.77 which we had been using, and before the release of 1.78. It is missing theto_string()
method thatboost::utility::string_view
has and that we had been calling.