Cancel overridden workflows #4597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
ckeshava
approved these changes
Jun 29, 2023
| @@ -57,7 +60,7 @@ jobs: | |||
| echo ${PATH} | tr ':' '\n' | |||
| conan --version | |||
| cmake --version | |||
| env | |||
| env | sort | |||
| - name: configure Conan | |||
| env: | |||
| CONAN_URL: http://18.143.149.228:8081/artifactory/api/conan/conan-non-prod | |||
There was a problem hiding this comment.
if the dns mapping changes in the future, won't we be in trouble because we have hard-coded the IP address?
There was a problem hiding this comment.
There is no domain name for this address. No mapping to change.
The risk is that the public IP address for this machine changes. We have already discussed, internally, adding a domain name for this machine. It will be an improvement, but it is not necessary.
Lastly, the IP address is already hard-coded in the workflows. It is not part of this PR.
thejohnfreeman
added
the
Passed
ximinez
pushed a commit
to ximinez/rippled
that referenced
this pull request
Jun 30, 2023
Small quality-of-life improvements to workflows using new concurrency control features: https://docs.github.com/en/actions/using-jobs/using-concurrency At time of this commit, macOS runners are oversubscribed. This may help.
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Jun 30, 2023
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Jun 30, 2023
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Jul 10, 2023
Small quality-of-life improvements to workflows using new concurrency control features: https://docs.github.com/en/actions/using-jobs/using-concurrency At time of this commit, macOS runners are oversubscribed. This may help.
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Sep 22, 2023
Small quality-of-life improvements to workflows using new concurrency control features: https://docs.github.com/en/actions/using-jobs/using-concurrency At time of this commit, macOS runners are oversubscribed. This may help.
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Sep 25, 2023
Small quality-of-life improvements to workflows using new concurrency control features: https://docs.github.com/en/actions/using-jobs/using-concurrency At time of this commit, macOS runners are oversubscribed. This may help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small quality-of-life improvements to workflows using new concurrency control features.