Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRIVIAL] Update checkout action version to resolve warning #4598

Merged
merged 3 commits into from
Jul 1, 2023

Conversation

ximinez
Copy link
Collaborator

@ximinez ximinez commented Jun 29, 2023

High Level Overview of Change

Update the version of the checkout action in clang-format.yml and levelization.yml

Context of Change

I noticed recently that some of the Github Actions had warnings:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Example:

The latest version is 3, so I updated the version in those jobs. I have noticed that more recent PRs don't have this warning, but I think it's worth updating the version anyway.

Test Plan

No C++ code was changed. This only affects CI, so there is nothing to test.

@ximinez ximinez requested a review from thejohnfreeman June 29, 2023 17:34
@ximinez ximinez added the CI Continuous Integration Functionality label Jun 29, 2023
@ximinez ximinez added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Jun 29, 2023
ximinez added 2 commits June 29, 2023 19:54
* upstream/develop:
  ci: cancel overridden workflows (4597)
  fix: Update Handler::Condition enum values 3417 (4239)
* upstream/develop:
  APIv2(account_info): handle invalid "signer_lists" value (4585)
  fix: deb package build (4591)
@intelliot intelliot merged commit 516ffb2 into XRPLF:develop Jul 1, 2023
ckeshava pushed a commit to ckeshava/rippled that referenced this pull request Jul 10, 2023
* Update the version of the checkout action (for GitHub Actions) in
  `clang-format.yml` and `levelization.yml`.
  * The previous version, v2, was raising deprecation warnings due to
    its reliance on Node.js 12.
  * The latest checkout action version, v3, uses Node.js 16.
ckeshava pushed a commit to ckeshava/rippled that referenced this pull request Sep 22, 2023
* Update the version of the checkout action (for GitHub Actions) in
  `clang-format.yml` and `levelization.yml`.
  * The previous version, v2, was raising deprecation warnings due to
    its reliance on Node.js 12.
  * The latest checkout action version, v3, uses Node.js 16.
ckeshava pushed a commit to ckeshava/rippled that referenced this pull request Sep 25, 2023
* Update the version of the checkout action (for GitHub Actions) in
  `clang-format.yml` and `levelization.yml`.
  * The previous version, v2, was raising deprecation warnings due to
    its reliance on Node.js 12.
  * The latest checkout action version, v3, uses Node.js 16.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Functionality Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants