Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix account_objects with invalid marker do not return an error #5046

Merged
merged 10 commits into from
Oct 29, 2024

Merge branch 'develop' into br_fix_account_obj_marker

8f1da51
Select commit
Loading
Failed to load commit list.
Merged

fix account_objects with invalid marker do not return an error #5046

Merge branch 'develop' into br_fix_account_obj_marker
8f1da51
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 29, 2024 in 0s

77.5% (target 60.0%)

View this Pull Request on Codecov

77.5% (target 60.0%)

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.5%. Comparing base (ab5d450) to head (8f1da51).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5046   +/-   ##
=======================================
  Coverage     77.5%   77.5%           
=======================================
  Files          777     777           
  Lines        65828   65831    +3     
  Branches      8207    8185   -22     
=======================================
+ Hits         50995   51025   +30     
+ Misses       14833   14806   -27     
Files with missing lines Coverage Δ
src/xrpld/rpc/detail/RPCHelpers.cpp 82.8% <100.0%> (+0.3%) ⬆️
src/xrpld/rpc/handlers/AccountObjects.cpp 96.2% <100.0%> (+0.7%) ⬆️

... and 6 files with indirect coverage changes

Impacted file tree graph