Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch Amendment #5060

Open
wants to merge 92 commits into
base: develop
Choose a base branch
from
Open

Batch Amendment #5060

wants to merge 92 commits into from
+3,359 −126

Commits on Jul 10, 2024

  1. featureBatch rough draft

    @dangell7
    dangell7 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    879aba5 View commit details
    Browse the repository at this point in the history

  2. clang-format

    @dangell7
    dangell7 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    46fd68f View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. add atomic swap

    @dangell7
    dangell7 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    c57ace7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature-batch

    @dangell7
    dangell7 authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    91d9909 View commit details
    Browse the repository at this point in the history

  3. add batch bsig

    @dangell7
    dangell7 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f37377d View commit details
    Browse the repository at this point in the history

  4. [fold] clang-format

    @dangell7
    dangell7 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    b3136a2 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. [fold] remove tapRETRY

    @dangell7
    dangell7 committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    5e919eb View commit details
    Browse the repository at this point in the history

  2. [fold] remove comments

    @dangell7
    dangell7 committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    1225a61 View commit details
    Browse the repository at this point in the history

  3. [fold] fix invariant workaround

    @dangell7
    dangell7 committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    304ff3e View commit details
    Browse the repository at this point in the history

  4. [fold] fix applyTransaction workaround

    @dangell7
    dangell7 committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    aded948 View commit details
    Browse the repository at this point in the history

  5. [fold] remove test template

    @dangell7
    dangell7 committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    82d4943 View commit details
    Browse the repository at this point in the history

  6. [fold] update logging

    @dangell7
    dangell7 committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    eaf7893 View commit details
    Browse the repository at this point in the history

  7. [fold] remove log

    @dangell7
    dangell7 committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    ca39807 View commit details
    Browse the repository at this point in the history

  8. clang-format

    @dangell7
    dangell7 committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    dd71073 View commit details
    Browse the repository at this point in the history

  9. [fold] remove workaround

    @dangell7
    dangell7 committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    26518a5 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. update atomic

    @dangell7
    dangell7 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    3ceb05c View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. refactor & OpenView revert() 

    This is not finished. Needs to only revert the transactions submitted not the entire open ledger.
    @dangell7
    dangell7 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    12324f1 View commit details
    Browse the repository at this point in the history

  2. [fold] clang-format

    @dangell7
    dangell7 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    e9f045b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into feature-batch

    @dangell7
    dangell7 authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    51ed234 View commit details
    Browse the repository at this point in the history

  4. [fold] add revert

    @dangell7
    dangell7 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    676b9b6 View commit details
    Browse the repository at this point in the history

  5. [fold] clang-format

    @dangell7
    dangell7 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    6c6180d View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. [revert] remove rawRevert func

    @dangell7
    dangell7 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    bd03ea3 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. refactor with stacking views

    @dangell7
    dangell7 committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    c0e00b0 View commit details
    Browse the repository at this point in the history

  2. clang-format

    @dangell7
    dangell7 committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    a3e15a1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into feature-batch

    @dangell7
    dangell7 authored Aug 3, 2024
    Configuration menu
    Copy the full SHA
    14eef60 View commit details
    Browse the repository at this point in the history

  4. [temp] invariant workaround

    @dangell7
    dangell7 committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    70e9931 View commit details
    Browse the repository at this point in the history

  5. update fields

    @dangell7
    dangell7 committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    c693b8f View commit details
    Browse the repository at this point in the history

  6. reject batch txn on submit

    @dangell7
    dangell7 committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    418836c View commit details
    Browse the repository at this point in the history

  7. clang-format

    @dangell7
    dangell7 committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    fe09972 View commit details
    Browse the repository at this point in the history

  8. add tests

    @dangell7
    dangell7 committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    a72b070 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. [fold] remove unused code

    @dangell7
    dangell7 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    0a45c16 View commit details
    Browse the repository at this point in the history

  2. include batch execution in tec failures

    @dangell7
    dangell7 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    2a0b9d4 View commit details
    Browse the repository at this point in the history

  3. atomic revert on non tec failures

    @dangell7
    dangell7 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    3a9963a View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. fix sequence & fee

    @dangell7
    dangell7 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    2c3c5c4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature-batch

    @dangell7
    dangell7 authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    a54a570 View commit details
    Browse the repository at this point in the history

  3. clang-format

    @dangell7
    dangell7 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    3ab585b View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. previousFields + nested views + signers

    @dangell7
    dangell7 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    26ee555 View commit details
    Browse the repository at this point in the history

  2. clang-format

    @dangell7
    dangell7 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    0d5242e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into feature-batch

    @dangell7
    dangell7 authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    51990ff View commit details
    Browse the repository at this point in the history

  4. add sfBatchResult

    @dangell7
    dangell7 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    ff7fa26 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Merge branch 'develop' into feature-batch

    @dangell7
    dangell7 authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    ae5abf5 View commit details
    Browse the repository at this point in the history

  2. ticket sequence

    @dangell7
    dangell7 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a78da6a View commit details
    Browse the repository at this point in the history

  3. fix metadata

    @dangell7
    dangell7 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    d3a2554 View commit details
    Browse the repository at this point in the history

  4. fix metadata

    @dangell7
    dangell7 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    e099e03 View commit details
    Browse the repository at this point in the history

  5. fix metadata

    @dangell7
    dangell7 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    84a69ef View commit details
    Browse the repository at this point in the history

  6. update tests

    @dangell7
    dangell7 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    f9fe787 View commit details
    Browse the repository at this point in the history

  7. clang-format

    @dangell7
    dangell7 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    0deea74 View commit details
    Browse the repository at this point in the history

  8. remove unused variable

    @dangell7
    dangell7 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9266676 View commit details
    Browse the repository at this point in the history

  9. rename func/field names

    @dangell7
    dangell7 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    3fff4ca View commit details
    Browse the repository at this point in the history

  10. clang-format

    @dangell7
    dangell7 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    ecfc64b View commit details
    Browse the repository at this point in the history

  11. [fold] remove log

    @dangell7
    dangell7 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    096f4bf View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Merge branch 'develop' into feature-batch

    @dangell7
    dangell7 authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    122368f View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. add sfTxIDs and update signing

    @dangell7
    dangell7 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    274660b View commit details
    Browse the repository at this point in the history

  2. clang-format

    @dangell7
    dangell7 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    04c5bde View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into feature-batch

    @dangell7
    dangell7 authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e4a5c52 View commit details
    Browse the repository at this point in the history

  4. [fixup] rerun actions

    @dangell7
    dangell7 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    659e705 View commit details
    Browse the repository at this point in the history

  5. [fixup] remove comments

    @dangell7
    dangell7 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    597e7fe View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. fix no account

    @dangell7
    dangell7 committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    639f8b7 View commit details
    Browse the repository at this point in the history

  2. clang-format

    @dangell7
    dangell7 committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    75fd76b View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Merge branch 'develop' into feature-batch

    @dangell7
    dangell7 authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    2925a5d View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Merge branch 'develop' into feature-batch

    @dangell7
    dangell7 authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    1367e03 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. [fold] remove comment

    @dangell7
    dangell7 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    f185d38 View commit details
    Browse the repository at this point in the history

  2. [fold] update headers

    @dangell7
    dangell7 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    767a88e View commit details
    Browse the repository at this point in the history

  3. [fold] change error response text

    @dangell7
    dangell7 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ee03811 View commit details
    Browse the repository at this point in the history

  4. [fold] change flags bit

    @dangell7
    dangell7 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    9d8368d View commit details
    Browse the repository at this point in the history

  5. [fold] fix formatting

    @dangell7
    dangell7 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    b408b80 View commit details
    Browse the repository at this point in the history

  6. [fold] normal consequences

    @dangell7
    dangell7 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    27d4685 View commit details
    Browse the repository at this point in the history

  7. [fold] refactor single/multi sign

    @dangell7
    dangell7 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    419b14d View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. [fold] review comments 

    - allow only one flag
- validate batch signers array (max and valid)
- move `calculateBaseFee`
- move `preflight2`
- no duplicate TxIDs
- no duplicate BatchSigners
    @dangell7
    dangell7 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    6c87e70 View commit details
    Browse the repository at this point in the history

  2. [fold] clang-format

    @dangell7
    dangell7 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a75cf0e View commit details
    Browse the repository at this point in the history

  3. [fold] tickets are not chronological

    @dangell7
    dangell7 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    e6021bf View commit details
    Browse the repository at this point in the history

  4. [fold] fix fee calculation

    @dangell7
    dangell7 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    fd0acb7 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into feature-batch

    @dangell7
    dangell7 authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    8a6d6ce View commit details
    Browse the repository at this point in the history

  6. [fold] fix merge issues

    @dangell7
    dangell7 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    dd77e03 View commit details
    Browse the repository at this point in the history

  7. [fold] clang-format

    @dangell7
    dangell7 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    6cb23e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. [fold] addressing review 

    - Update Comments
- Update/Change function names
- Update/Change argument names
- Remove unused preclaim
- Fix exit out of signature check (multi & single)
    @dangell7
    dangell7 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    88c40e4 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. [fold] change sequence handling 

    - Remove BatchTxn Object
- Use Global Flag `tfInnerBatchTxn ` for inner batch txns
- Remove Sequence & Ticket workaround
- replace sfBatchTxn submit/relay validation with tfInnerBatchTxn
- Remove Sequence 0 Requirement
    @dangell7
    dangell7 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    e4cb784 View commit details
    Browse the repository at this point in the history

  2. [fixup] rename prevFields -> batchPrevAcctRootFields

    @dangell7
    dangell7 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    47120ac View commit details
    Browse the repository at this point in the history

  3. [fold] revert applyFlags change

    @dangell7
    dangell7 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    6ed4ac8 View commit details
    Browse the repository at this point in the history

  4. [fold] use unordered_set

    @dangell7
    dangell7 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    52f1ba9 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into feature-batch

    @dangell7
    dangell7 authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    1978fd3 View commit details
    Browse the repository at this point in the history

  6. [fold] clang-format

    @dangell7
    dangell7 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    6ffe349 View commit details
    Browse the repository at this point in the history

  7. [fold] fix bad merge

    @dangell7
    dangell7 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    04519e6 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. [fold] address review 

    - fix comments
- rename batch executions
    @dangell7
    dangell7 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    8029c30 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. [fold] add quorum and out of order test

    @dangell7
    dangell7 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    7e60777 View commit details
    Browse the repository at this point in the history

  2. [fold] add view change test 

    This test confirms that the fee is taken from the batch txn first, then subsequent transactions.
    @dangell7
    dangell7 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    403599b View commit details
    Browse the repository at this point in the history

  3. [fold] update to spec (BatchExecution) 

    - remove TransactionType from BatchExecution
- add TxHash to all results (not just tec/tes)
- update tests to verify hashes
    @dangell7
    dangell7 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    d18e9b3 View commit details
    Browse the repository at this point in the history

  4. [fold] add test 

    Test where inner batch is missing TransactionType
    @dangell7
    dangell7 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    afe58ab View commit details
    Browse the repository at this point in the history

  5. [fold] add comments for Transactor.reset()

    @dangell7
    dangell7 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    aec8268 View commit details
    Browse the repository at this point in the history

  6. [fold] add/update tests

    @dangell7
    dangell7 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    086e6b0 View commit details
    Browse the repository at this point in the history

  7. [fold] add tests 

    - outer signer cannot include a batch signature
- inner txn cannot include a fee
    @dangell7
    dangell7 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    2ea9fe6 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. [fold] apply open view on open and closed

    @dangell7
    dangell7 committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    776aabc View commit details
    Browse the repository at this point in the history