Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash inside OverlayImpl loops over ids_ #5071

Merged
merged 8 commits into from
Aug 2, 2024

Merge branch 'develop' into bugfix/crash_in_OverlayImpl_loops

c3deeff
Select commit
Loading
Failed to load commit list.
Merged

Fix crash inside OverlayImpl loops over ids_ #5071

Merge branch 'develop' into bugfix/crash_in_OverlayImpl_loops
c3deeff
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 2, 2024 in 0s

71.3% (target 60.0%)

View this Pull Request on Codecov

71.3% (target 60.0%)

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.3%. Comparing base (e5aa605) to head (c3deeff).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5071     +/-   ##
=========================================
- Coverage     71.4%   71.3%   -0.0%     
=========================================
  Files          796     796             
  Lines        67073   67075      +2     
  Branches     10866   10881     +15     
=========================================
- Hits         47881   47854     -27     
- Misses       19192   19221     +29     
Files Coverage Δ
src/xrpld/overlay/detail/OverlayImpl.cpp 29.8% <100.0%> (+1.1%) ⬆️

... and 8 files with indirect coverage changes

Impacted file tree graph