-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce MPT support (XLS-33d): #5143
Merged
Merged
Changes from 1 commit
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
6d6fda2
Introduce MPT support (XLS-33d):
gregtatcam aaf7fe5
Merge branch 'develop' into feature/mpt-v1-var-issues
gregtatcam f84e9ea
Apply suggestions from code review
gregtatcam 18515dd
Address reviewer's feedback
gregtatcam aef1426
Allow MPT SendMax in Payment tx.
gregtatcam 9136a89
Apply suggestions from code review
gregtatcam 16a029a
Address reviewer's feedback
gregtatcam 2beb2d9
Manually align jss and disable clang-format
gregtatcam 3cc7003
Apply suggestions from code review
gregtatcam 069273c
Fix clang format
gregtatcam 86bcebd
Apply suggestions from code review
gregtatcam b9cb9ca
Address reviewer's feedback
gregtatcam 8af452e
remove unneeded fields (#36)
shawnxie999 fab0c78
rename codes (#37)
shawnxie999 ea887bf
Address reviewer feedback
gregtatcam d9fc97f
Check Payment's sendMax and amount have the same issue
gregtatcam 98d419f
Apply suggestions from code review
gregtatcam 3b7861d
Address reviewer's feedback
gregtatcam 93c545d
Fix static_assert in STVar and other changes
gregtatcam aacb1c8
comment (#38)
shawnxie999 560cf91
Fix SendMax with no transfer fee
gregtatcam 6a7a8c2
Combine Issue/MPTIssue handling in Payment transactor plus other changes
gregtatcam 8796641
Fix non-unity build
gregtatcam 757b55a
Update src/libxrpl/protocol/TxFormats.cpp
gregtatcam 11aa41c
New SField flag to override hex input/output formatting to use decima…
ximinez eac438c
Change maxAmount in the test to uint64 for better visualization
gregtatcam 9d51389
Refactor Clawback plus other minor refactoring
gregtatcam 8774b90
Fix requireAuth (#40)
shawnxie999 4bcf463
Address reviewer's feedback
gregtatcam 9b8564e
Fix metadata and add metadata unit-test
gregtatcam ac45342
Address reviewer's feedback:
gregtatcam af29f41
use mptJson
shawnxie999 9e3cfef
Add += and -= operators to ValueProxy
gregtatcam 4bbf613
ledger_entry test (#41)
shawnxie999 3bb44c2
Simplify constraint for +=, -= of ValueProxy
gregtatcam 0bf5b42
Address reviewer's feedback on mpt uni-test helper
gregtatcam 924dd9c
refactor mpt_issuance_id into SLE::getJson (#42)
shawnxie999 31b3be3
Merge branch 'develop' into feature/mpt-v1-var-issues
gregtatcam c3f2bd4
Fix clang-format
gregtatcam 29c6f5d
Merge with the latest develop
gregtatcam bd97cc9
Address reviewer's feedback
gregtatcam 38781df
Fix inline isFrozen definition
gregtatcam e239fcb
Address reviewer feedback
gregtatcam fe6fa60
Fix clang-format
gregtatcam f4bc120
Address reviewer's feedback
gregtatcam 780af7a
removed mptHolders (#43)
shawnxie999 e4009c8
address comments (#44)
shawnxie999 5f33c80
move flags (#45)
shawnxie999 e8c8329
Address reviewer's feedback - refactor mpt.[h,cpp]
gregtatcam c53df59
Apply suggestions from code review - update MPT unit-tests
gregtatcam b8f3b83
Fix clang-format
gregtatcam 5349827
Address reviewer's feedback - add MPT unit-tests
gregtatcam 0905e37
Apply suggestions from code review
gregtatcam 9d84f3b
Address reviewer's feedback
gregtatcam e8201f3
address comments (#46)
shawnxie999 5aa36e4
Apply suggestions from code review
gregtatcam 7a6272e
Address reviewer's feedback
gregtatcam 3439bfa
comments (#48)
shawnxie999 b636836
Rename mpt holder (#49)
shawnxie999 7c08b58
Address reviewer's feedback
gregtatcam 9ce2061
Ed's comments (#50)
shawnxie999 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
Rename mpt holder (#49)
* rename * space
commit b636836a47b48f758d64ca4ea96ee42a5035fde3
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good to keep the same informative error codes returned by
preclaim()
, here and elsewhere. Consider future callers trying to debug.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rule that I observ is that errors in
apply
are generally tecINTERNAL since the these errors should've already been caught in the preclaim in the first place, so we'd never expect this condition be triggered.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that's a good reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is practice the codebase currently has, not sure if we want to change it. Perhaps @ximinez can weigh in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If something has already been checked in an earlier step (like
preflight
orpreclaim
), and thus should be impossible, then our practice has been to returntef/tecINTERNAL
in later steps.Think of it more like an
assert
: We want to know something went wrong, but we don't want to crash the server. Particularly withtecINTERNAL
, if we see that on a validated ledger, we know something bad happened, and we can replay the transaction to see what happened and fix it. If we just return the same error codes thatpreclaim()
returned, we'd never know there was a problem.