Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Conan 2.x #5219

Draft
wants to merge 33 commits into
base: develop
Choose a base branch
from
Draft

Conversation

thejohnfreeman
Copy link
Collaborator

This is a draft branch for testing CI with Conan 2.x. Contributors should switch soon. Conan 1.x package recipes are now frozen. They will no longer receive updates. The project builds just fine with Conan 2.x, and we can even simplify the build instructions.

@thejohnfreeman
Copy link
Collaborator Author

Current state:

  • macOS works.
  • Linux: dependencies job works, but test job fails when trying to run conan --version in the check environment step.
  • Windows: takes forever. have never waited for the outcome, but appears to work.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (ea1fffe) to head (53b620a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5219     +/-   ##
=========================================
- Coverage     77.9%   77.9%   -0.0%     
=========================================
  Files          783     783             
  Lines        66677   66677             
  Branches      8108    8108             
=========================================
- Hits         51921   51918      -3     
- Misses       14756   14759      +3     

see 3 files with indirect coverage changes

Impacted file tree graph

@thejohnfreeman
Copy link
Collaborator Author

I believe this latest state will work for all checks. macOS may fail with 1 flaky error, as it has been doing for weeks. Everything else should pass.

@thejohnfreeman thejohnfreeman marked this pull request as ready for review December 11, 2024 23:48
@thejohnfreeman thejohnfreeman marked this pull request as draft December 13, 2024 17:07
@thejohnfreeman
Copy link
Collaborator Author

Where I left off:

  • Windows build has a runtime mismatch. Perhaps Conan 2.x requires a different way to configure MSVC runtime. Need to investigate.
  • conan test to build the example project that depends on xrpl is failing because Conan 2.x does not support the --require-override option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant