Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nftoken_id, nftoken_ids, offer_id to meta for transaction stream #5230

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

tequdev
Copy link
Contributor

@tequdev tequdev commented Dec 20, 2024

High Level Overview of Change

As the title says.

Type of Change

  • [x ] Bug fix (non-breaking change which fixes an issue)

close #5229

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (49e0d54) to head (7faa6da).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5230     +/-   ##
=========================================
- Coverage     77.9%   77.9%   -0.0%     
=========================================
  Files          783     783             
  Lines        66707   66708      +1     
  Branches      8140    8118     -22     
=========================================
- Hits         51964   51957      -7     
- Misses       14743   14751      +8     
Files with missing lines Coverage Δ
src/libxrpl/protocol/NFTSyntheticSerializer.cpp 100.0% <ø> (ø)
src/xrpld/app/misc/NetworkOPs.cpp 70.1% <100.0%> (+<0.1%) ⬆️
src/xrpld/rpc/handlers/AccountTx.cpp 87.9% <100.0%> (ø)
src/xrpld/rpc/handlers/Tx.cpp 90.5% <100.0%> (ø)

... and 6 files with indirect coverage changes

Impacted file tree graph

@mvadari
Copy link
Collaborator

mvadari commented Dec 20, 2024

Please add tests

@tequdev
Copy link
Contributor Author

tequdev commented Dec 22, 2024

Please add tests

added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants