Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for ED25519 seeds that don't use the sEd prefix #415

Merged
merged 7 commits into from
Jul 26, 2022

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Jul 6, 2022

High Level Overview of Change

The library currently assumes that all ed25519 seeds use the sEd prefix. However, this is not necessarily true - they can also just have the s prefix, like the secp256k1 seeds.

This PR adds support for those ed25519 seeds.

Context of Change

needed for sidechains work

Type of Change

  • New feature (non-breaking change which adds functionality)

Test Plan

CI passes. Added tests to test the new functionality.

@mvadari mvadari marked this pull request as ready for review July 12, 2022 14:18
@mvadari mvadari force-pushed the ed-wallet branch 2 times, most recently from ccc27e7 to de3687e Compare July 12, 2022 14:34
@mvadari mvadari requested review from JST5000 and khancode July 19, 2022 10:36
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@JST5000 JST5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants