Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: Refactored wallet class and removed wallet sequence #477

Merged
merged 53 commits into from
Dec 14, 2022
Merged

breaking: Refactored wallet class and removed wallet sequence #477

merged 53 commits into from
Dec 14, 2022

Conversation

connorjchen
Copy link
Collaborator

@connorjchen connorjchen commented Nov 22, 2022 •
edited
Loading

High Level Overview of Change

  • Complete revamped wallet class to be more alike to xrpl.js (breaking changes)
  • Some (breaking) changes to key formatting and seed generation with given entropy

Context of Change

xrpl-py wallet class was outdated and lacked many functions that xrpl.js offers
https://docs.google.com/document/d/1G_5H40eD1gKaue6XgdecP5SYifrljkCjtGsZnVZDLyo/edit#

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Test Plan

wrote entire test suite for wallet class

@connorjchen
Set up wallet tests
09f7cc1
@connorjchen
Change list to List
b11be17
@connorjchen
Wrote some wallet tests
2a840ec
@connorjchen
Isolate bad test
7c28d0f
@connorjchen
Removed a test
c144ad2
@connorjchen
Add address alias
5164e8e
@connorjchen
Fix default algorithm for public/private key
864ef1c
@connorjchen
Wrote main wallet tests for generation
336cbfa
@connorjchen
Add from_secret tests
1695392
@connorjchen
Merge branch 'master' into wallet-generation
60fd94d
@connorjchen
Remove breaking change for algorithm optional on wallet init
babb5da
@connorjchen
Merge branch 'wallet-generation' of https://github.com/connorjchen/xr…
80a11fd 
…pl-py into wallet-generation
@connorjchen
Remove default algo for wallet init
7bd8f7c
@connorjchen
Reverted behavior of default algorithm for from_seed and init
597510c
@connorjchen
Fix docstrings
f6bfa6c
@connorjchen
Deprecate wallet create
8bf5176
@connorjchen
Changed wallet class to look alike xrpljs
4cf72bb
@connorjchen
Add tests to wallet refactor
6627b05
@connorjchen
Remove changelog changes
a2a556b
@connorjchen
Fix changelog difference'
ce5db90
@connorjchen
Shortened address function
3119fd4
@connorjchen
Empty test commit
7e62397
@connorjchen
Updated CHANGELOG
6669b3c
@connorjchen
Fix tests for sequence removal
028613e
@connorjchen connorjchen changed the title breaking: Refactored wallet class breaking: Refactored wallet class and removed wallet sequence Nov 23, 2022
@connorjchen connorjchen marked this pull request as ready for review November 23, 2022 19:39
JST5000
JST5000 approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@JST5000 JST5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

mvadari
mvadari reviewed Dec 14, 2022
View reviewed changes
xrpl/wallet/main.py Outdated Show resolved Hide resolved
JST5000
JST5000 approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@JST5000 JST5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@connorjchen connorjchen merged commit 2be6a3e into XRPLF:xrpl-py-2.0 Dec 14, 2022
JST5000 pushed a commit that referenced this pull request Jun 28, 2023
@connorjchen @JST5000
breaking: Refactored wallet class and removed wallet sequence (#477)
3e164eb 
* Refactored wallet class and tests

* Fix leading zero for key formatting

* Changed from_entropy to take in hex string

* Update core keypairs docs

* Throw error instead truncate for generate seed with entropy

* Refactor test main wallet generation suite
JST5000 pushed a commit that referenced this pull request Jun 28, 2023
@connorjchen @JST5000
breaking: Refactored wallet class and removed wallet sequence (#477)
5b47b35 
* Refactored wallet class and tests

* Fix leading zero for key formatting

* Changed from_entropy to take in hex string

* Update core keypairs docs

* Throw error instead truncate for generate seed with entropy

* Refactor test main wallet generation suite
JST5000 pushed a commit that referenced this pull request Jul 5, 2023
@connorjchen @JST5000
breaking: Refactored wallet class and removed wallet sequence (#477)
ba2a246 
* Refactored wallet class and tests

* Fix leading zero for key formatting

* Changed from_entropy to take in hex string

* Update core keypairs docs

* Throw error instead truncate for generate seed with entropy

* Refactor test main wallet generation suite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JST5000 JST5000 JST5000 approved these changes

@mvadari mvadari mvadari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjchen @mvadari @JST5000