fix: assorted fixes #570
fix: assorted fixes #570
Conversation
| elif self.signer_quorum <= 0: | ||
| errors[ | ||
| "signer_quorum" | ||
| ] = "`signer_quorum` must be greater than or equal to 0." |
There was a problem hiding this comment.
This error says that signer_quorum must be greater than or equal to 0, but if it is 0 this error still happens. Is that a typo?
There was a problem hiding this comment.
Hm, not sure - it appears to have been the same previously.
There was a problem hiding this comment.
Based on definition here:
https://xrpl.org/signerlistset.html#signerlistset-fields
It seems 0 is still valid to delete the signer list so the if condition should be modified?
There was a problem hiding this comment.
Looking at the code again, I think this condition is fine - line 97 returns errors if signer_entries is None, which should handle that situation.
There was a problem hiding this comment.
You're right. Then should the error message be "signer_quorum must be greater than 0 when signer_list is not being deleted." since deletion cases have been handled in lines 86-98?
There was a problem hiding this comment.
@mvadari I think updating the error to what @pdp2121 suggested makes sense here -
Relevant quote from xrpl.org on SignerlistSet fields: (https://xrpl.org/signerlistset.html#signerlistset-fields)
"You cannot create a signer list such that the SignerQuorum could never be met. The SignerQuorum must be greater than 0 but less than or equal to the sum of the SignerWeight values in the list. Otherwise, the transaction fails with the error temMALFORMED."
There was a problem hiding this comment.
Error message was fixed in this commit: e3b0f0eb9f262ed3ae3cdcbc5f6c59fc47432f3c
High Level Overview of Change
This PR:
keypairs.signto take a hex string in addition to bytesSignerListSetvalidationContext of Change
These were all issues I came across while working on #571.
Type of Change
Test Plan
CI passes.