Remove deprecated request functions (attempt 2) #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ckniffen
approved these changes
May 31, 2023
JST5000
added a commit
that referenced
this pull request
Jun 28, 2023
* Remove deprecated functions * Fix isort --------- Co-authored-by: Caleb Kniffen <ckniffen@ripple.com>
JST5000
added a commit
that referenced
this pull request
Jun 28, 2023
* Remove deprecated functions * Fix isort --------- Co-authored-by: Caleb Kniffen <ckniffen@ripple.com>
JST5000
added a commit
that referenced
this pull request
Jul 5, 2023
* Remove deprecated functions * Fix isort --------- Co-authored-by: Caleb Kniffen <ckniffen@ripple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Remove requests that were deprecated for the 2.0 release.
Context of Change
Many request wrappers were just as complicated to use, and their return types were too simplistic in many situations. Instead, we recommend directly calling the request with a
Requestobject andclient.request.Type of Change
Test Plan
CI Passes