refactor: Make param order for signing/submitting consistent #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckniffen
approved these changes
Jun 15, 2023
justinr1234
changed the title
justinr1234
approved these changes
Jun 15, 2023
JST5000
added a commit
that referenced
this pull request
Jun 28, 2023
* Update the CHANGELOG * Update `autofill_and_sign` and `sign_and_submit`
JST5000
added a commit
that referenced
this pull request
Jun 28, 2023
* Update the CHANGELOG * Update `autofill_and_sign` and `sign_and_submit`
JST5000
added a commit
that referenced
this pull request
Jul 5, 2023
* Update the CHANGELOG * Update `autofill_and_sign` and `sign_and_submit`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
submit_and_waitchanged the param order sinceWalletis optional, so we want to make all similar functions follow the same order to reduce confusion/frustration.Context of Change
In order to be internally consistent, all signing/submitting functions will follow the parameter order of
transaction,client,wallet, and then other parameters. (This is becausewalletis optional forsubmit_and_waitand so must come afterclient)This affects
autofill_and_signandsign_and_submit.Type of Change
Test Plan
CI Passes